Keep writing-mode in sync between a column spanner and its placeholder.

Keep writing-mode in sync between a column spanner and its placeholder.

Don't exclude LayoutMultiColumnSpannerPlaceholder (which is just a LayoutBox)
in propagateStyleToAnonymousChildren(). There was an optional requirement for
the child to be LayoutBlock or better, but there really doesn't seem to be
any point in doing this. We no longer create anonymous LayoutInline objects,
ever, anyway (will file a separate CL to remove some unneeded support code
for that in LayoutInline).

All we need to do now is to steer clear of such anonymous objects that have
custom ways of inheriting style. LayoutFullScreen and
LayoutFullScreenPlaceholder were already taken care of. Now that we always
try to propagate style to non-LayoutBlock objects as well, we need to avoid
LayoutListMarker too.

BUG=608123
Committed: https://crrev.com/88b19ef7788c9b388cf5eb877d75c264d81e4298
Cr-Commit-Position: refs/heads/master@{#395107}

[mstensho (USE GERRIT), 2016-05-20 16:31:50]

Description was changed from

==========
Keep writing-mode in sync between a column spanner and its placeholder.

Don't exclude the spanner placeholder (which is just a LayoutBox) in
propagateStyleToAnonymousChildren(). There was a requirement for the child to
be LayoutBlock or better, but there really doesn't seem to be any need for
this. We no longer create anonymous LayoutInline objects, ever, anyway (will
file a separate CL to remove some unneeded support code for that in
LayoutInline).

BUG=608123
==========

to

==========
Keep writing-mode in sync between a column spanner and its placeholder.

Don't exclude the spanner placeholder (which is just a LayoutBox) in
propagateStyleToAnonymousChildren(). There was an optional requirement for
the child to be LayoutBlock or better, but there really doesn't seem to be
any point in doing this. We no longer create anonymous LayoutInline objects,
ever, anyway (will file a separate CL to remove some unneeded support code
for that in LayoutInline).

All we need to do is to steer clear of such anonymous objects that have
custom ways of inheriting style. LayoutFullScreen and
LayoutFullScreenPlaceholder were already taken care of. Now that we always
try to propagate style to non-LayoutBlock objects as well, we need to avoid
LayoutListMarker too.

BUG=608123
==========

[mstensho (USE GERRIT), 2016-05-20 16:36:56]

Description was changed from

==========
Keep writing-mode in sync between a column spanner and its placeholder.

Don't exclude the spanner placeholder (which is just a LayoutBox) in
propagateStyleToAnonymousChildren(). There was an optional requirement for
the child to be LayoutBlock or better, but there really doesn't seem to be
any point in doing this. We no longer create anonymous LayoutInline objects,
ever, anyway (will file a separate CL to remove some unneeded support code
for that in LayoutInline).

All we need to do is to steer clear of such anonymous objects that have
custom ways of inheriting style. LayoutFullScreen and
LayoutFullScreenPlaceholder were already taken care of. Now that we always
try to propagate style to non-LayoutBlock objects as well, we need to avoid
LayoutListMarker too.

BUG=608123
==========

to

==========
Keep writing-mode in sync between a column spanner and its placeholder.

Don't exclude LayoutMultiColumnSpannerPlaceholder (which is just a LayoutBox)
in propagateStyleToAnonymousChildren(). There was an optional requirement for
the child to be LayoutBlock or better, but there really doesn't seem to be
any point in doing this. We no longer create anonymous LayoutInline objects,
ever, anyway (will file a separate CL to remove some unneeded support code
for that in LayoutInline).

All we need to do now is to steer clear of such anonymous objects that have
custom ways of inheriting style. LayoutFullScreen and
LayoutFullScreenPlaceholder were already taken care of. Now that we always
try to propagate style to non-LayoutBlock objects as well, we need to avoid
LayoutListMarker too.

BUG=608123
==========

[mstensho (USE GERRIT), 2016-05-20 16:39:07]

mstensho@opera.com changed reviewers:
+ eae@chromium.org, szager@chromium.org, wkorman@chromium.org

[mstensho (USE GERRIT), 2016-05-20 16:39:09]

https://codereview.chromium.org/2000683002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/LayoutObject.cpp (right):

https://codereview.chromium.org/2000683002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/LayoutObject.cpp:2132: if
(child->anonymousHasStylePropagationOverride())
Does anyone have a fancier name than this? :)

https://codereview.chromium.org/2000683002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/LayoutObject.cpp:2139: if
(child->isInFlowPositioned() && child->isLayoutBlock() &&
toLayoutBlock(child)->isAnonymousBlockContinuation())
It only seems right to type-check here. Now more than ever. I'm pretty sure we
cannot have "in-flow" positioned (i.e. relative) anonymous non-blocks, but
still...

[eae, 2016-05-20 17:02:04]

LGTM

https://codereview.chromium.org/2000683002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/LayoutObject.cpp (right):

https://codereview.chromium.org/2000683002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/LayoutObject.cpp:2132: if
(child->anonymousHasStylePropagationOverride())
On 2016/05/20 16:39:09, mstensho wrote:
> Does anyone have a fancier name than this? :)

While it doesn't exactly roll of the tongue it gets the message across.

https://codereview.chromium.org/2000683002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/LayoutObject.cpp:2139: if
(child->isInFlowPositioned() && child->isLayoutBlock() &&
toLayoutBlock(child)->isAnonymousBlockContinuation())
On 2016/05/20 16:39:09, mstensho wrote:
> It only seems right to type-check here. Now more than ever. I'm pretty sure we
> cannot have "in-flow" positioned (i.e. relative) anonymous non-blocks, but
> still...

Acknowledged.

[mstensho (USE GERRIT), 2016-05-20 17:26:09]

The CQ bit was checked by mstensho@opera.com

[commit-bot: I haz the power, 2016-05-20 17:26:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2000683002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2000683002/40001

[commit-bot: I haz the power, 2016-05-20 17:31:12]

Description was changed from

==========
Keep writing-mode in sync between a column spanner and its placeholder.

Don't exclude LayoutMultiColumnSpannerPlaceholder (which is just a LayoutBox)
in propagateStyleToAnonymousChildren(). There was an optional requirement for
the child to be LayoutBlock or better, but there really doesn't seem to be
any point in doing this. We no longer create anonymous LayoutInline objects,
ever, anyway (will file a separate CL to remove some unneeded support code
for that in LayoutInline).

All we need to do now is to steer clear of such anonymous objects that have
custom ways of inheriting style. LayoutFullScreen and
LayoutFullScreenPlaceholder were already taken care of. Now that we always
try to propagate style to non-LayoutBlock objects as well, we need to avoid
LayoutListMarker too.

BUG=608123
==========

to

==========
Keep writing-mode in sync between a column spanner and its placeholder.

Don't exclude LayoutMultiColumnSpannerPlaceholder (which is just a LayoutBox)
in propagateStyleToAnonymousChildren(). There was an optional requirement for
the child to be LayoutBlock or better, but there really doesn't seem to be
any point in doing this. We no longer create anonymous LayoutInline objects,
ever, anyway (will file a separate CL to remove some unneeded support code
for that in LayoutInline).

All we need to do now is to steer clear of such anonymous objects that have
custom ways of inheriting style. LayoutFullScreen and
LayoutFullScreenPlaceholder were already taken care of. Now that we always
try to propagate style to non-LayoutBlock objects as well, we need to avoid
LayoutListMarker too.

BUG=608123
==========

[commit-bot: I haz the power, 2016-05-20 17:31:16]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-20 17:32:30]

Description was changed from

==========
Keep writing-mode in sync between a column spanner and its placeholder.

Don't exclude LayoutMultiColumnSpannerPlaceholder (which is just a LayoutBox)
in propagateStyleToAnonymousChildren(). There was an optional requirement for
the child to be LayoutBlock or better, but there really doesn't seem to be
any point in doing this. We no longer create anonymous LayoutInline objects,
ever, anyway (will file a separate CL to remove some unneeded support code
for that in LayoutInline).

All we need to do now is to steer clear of such anonymous objects that have
custom ways of inheriting style. LayoutFullScreen and
LayoutFullScreenPlaceholder were already taken care of. Now that we always
try to propagate style to non-LayoutBlock objects as well, we need to avoid
LayoutListMarker too.

BUG=608123
==========

to

==========
Keep writing-mode in sync between a column spanner and its placeholder.

Don't exclude LayoutMultiColumnSpannerPlaceholder (which is just a LayoutBox)
in propagateStyleToAnonymousChildren(). There was an optional requirement for
the child to be LayoutBlock or better, but there really doesn't seem to be
any point in doing this. We no longer create anonymous LayoutInline objects,
ever, anyway (will file a separate CL to remove some unneeded support code
for that in LayoutInline).

All we need to do now is to steer clear of such anonymous objects that have
custom ways of inheriting style. LayoutFullScreen and
LayoutFullScreenPlaceholder were already taken care of. Now that we always
try to propagate style to non-LayoutBlock objects as well, we need to avoid
LayoutListMarker too.

BUG=608123

Committed: https://crrev.com/88b19ef7788c9b388cf5eb877d75c264d81e4298
Cr-Commit-Position: refs/heads/master@{#395107}
==========

[commit-bot: I haz the power, 2016-05-20 17:32:31]

Patchset 3 (id:??) landed as
https://crrev.com/88b19ef7788c9b388cf5eb877d75c264d81e4298
Cr-Commit-Position: refs/heads/master@{#395107}