Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutFullScreen.cpp

Issue 2000683002: Keep writing-mode in sync between a column spanner and its placeholder. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: There should no longer be any need for LayoutTable to propagateStyleToAnonymousChildren(), since La… Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Apple Inc. All rights reserved. 2 * Copyright (C) 2010 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 30 matching lines...) Expand all
41 , m_owner(owner) 41 , m_owner(owner)
42 { 42 {
43 setDocumentForAnonymous(&owner->document()); 43 setDocumentForAnonymous(&owner->document());
44 } 44 }
45 45
46 // Must call setStyleWithWritingModeOfParent() instead. 46 // Must call setStyleWithWritingModeOfParent() instead.
47 void setStyle(PassRefPtr<ComputedStyle>) = delete; 47 void setStyle(PassRefPtr<ComputedStyle>) = delete;
48 48
49 private: 49 private:
50 bool isOfType(LayoutObjectType type) const override { return type == LayoutO bjectLayoutFullScreenPlaceholder || LayoutBlockFlow::isOfType(type); } 50 bool isOfType(LayoutObjectType type) const override { return type == LayoutO bjectLayoutFullScreenPlaceholder || LayoutBlockFlow::isOfType(type); }
51 bool anonymousHasStylePropagationOverride() override { return true; }
52
51 void willBeDestroyed() override; 53 void willBeDestroyed() override;
52 LayoutFullScreen* m_owner; 54 LayoutFullScreen* m_owner;
53 }; 55 };
54 56
55 void LayoutFullScreenPlaceholder::willBeDestroyed() 57 void LayoutFullScreenPlaceholder::willBeDestroyed()
56 { 58 {
57 m_owner->resetPlaceholder(); 59 m_owner->resetPlaceholder();
58 LayoutBlockFlow::willBeDestroyed(); 60 LayoutBlockFlow::willBeDestroyed();
59 } 61 }
60 62
(...skipping 133 matching lines...) Expand 10 before | Expand all | Expand 10 after
194 m_placeholder->setStyleWithWritingModeOfParent(style); 196 m_placeholder->setStyleWithWritingModeOfParent(style);
195 if (parent()) { 197 if (parent()) {
196 parent()->addChildWithWritingModeOfParent(m_placeholder, this); 198 parent()->addChildWithWritingModeOfParent(m_placeholder, this);
197 parent()->setNeedsLayoutAndPrefWidthsRecalcAndFullPaintInvalidation( LayoutInvalidationReason::Fullscreen); 199 parent()->setNeedsLayoutAndPrefWidthsRecalcAndFullPaintInvalidation( LayoutInvalidationReason::Fullscreen);
198 } 200 }
199 } else { 201 } else {
200 m_placeholder->setStyle(style); 202 m_placeholder->setStyle(style);
201 m_placeholder->setStyleWithWritingModeOfParent(style); 203 m_placeholder->setStyleWithWritingModeOfParent(style);
202 } 204 }
203 } 205 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698