Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutTable.cpp

Issue 2000683002: Keep writing-mode in sync between a column spanner and its placeholder. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: There should no longer be any need for LayoutTable to propagateStyleToAnonymousChildren(), since La… Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 * Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 * (C) 1997 Torben Weis (weis@kde.org) 3 * (C) 1997 Torben Weis (weis@kde.org)
4 * (C) 1998 Waldo Bastian (bastian@kde.org) 4 * (C) 1998 Waldo Bastian (bastian@kde.org)
5 * (C) 1999 Lars Knoll (knoll@kde.org) 5 * (C) 1999 Lars Knoll (knoll@kde.org)
6 * (C) 1999 Antti Koivisto (koivisto@kde.org) 6 * (C) 1999 Antti Koivisto (koivisto@kde.org)
7 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2013 Apple Inc. All rights reserved. 7 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2013 Apple Inc. All rights reserved.
8 * Copyright (C) 2006 Alexey Proskuryakov (ap@nypop.com) 8 * Copyright (C) 2006 Alexey Proskuryakov (ap@nypop.com)
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
69 m_effectiveColumnPositions.fill(0, 1); 69 m_effectiveColumnPositions.fill(0, 1);
70 } 70 }
71 71
72 LayoutTable::~LayoutTable() 72 LayoutTable::~LayoutTable()
73 { 73 {
74 } 74 }
75 75
76 void LayoutTable::styleDidChange(StyleDifference diff, const ComputedStyle* oldS tyle) 76 void LayoutTable::styleDidChange(StyleDifference diff, const ComputedStyle* oldS tyle)
77 { 77 {
78 LayoutBlock::styleDidChange(diff, oldStyle); 78 LayoutBlock::styleDidChange(diff, oldStyle);
79 propagateStyleToAnonymousChildren();
80 79
81 bool oldFixedTableLayout = oldStyle ? oldStyle->isFixedTableLayout() : false ; 80 bool oldFixedTableLayout = oldStyle ? oldStyle->isFixedTableLayout() : false ;
82 81
83 // In the collapsed border model, there is no cell spacing. 82 // In the collapsed border model, there is no cell spacing.
84 m_hSpacing = collapseBorders() ? 0 : style()->horizontalBorderSpacing(); 83 m_hSpacing = collapseBorders() ? 0 : style()->horizontalBorderSpacing();
85 m_vSpacing = collapseBorders() ? 0 : style()->verticalBorderSpacing(); 84 m_vSpacing = collapseBorders() ? 0 : style()->verticalBorderSpacing();
86 m_effectiveColumnPositions[0] = m_hSpacing; 85 m_effectiveColumnPositions[0] = m_hSpacing;
87 86
88 if (!m_tableLayout || style()->isFixedTableLayout() != oldFixedTableLayout) { 87 if (!m_tableLayout || style()->isFixedTableLayout() != oldFixedTableLayout) {
89 if (m_tableLayout) 88 if (m_tableLayout)
(...skipping 1406 matching lines...) Expand 10 before | Expand all | Expand 10 after
1496 1495
1497 LayoutUnit LayoutTable::paddingRight() const 1496 LayoutUnit LayoutTable::paddingRight() const
1498 { 1497 {
1499 if (collapseBorders()) 1498 if (collapseBorders())
1500 return LayoutUnit(); 1499 return LayoutUnit();
1501 1500
1502 return LayoutBlock::paddingRight(); 1501 return LayoutBlock::paddingRight();
1503 } 1502 }
1504 1503
1505 } // namespace blink 1504 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698