Keep writing-mode in sync between a column spanner and its placeholder.

third_party/WebKit/Source/core/layout/LayoutObject.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2000 Dirk Mueller (mueller@kde.org)
  *           (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2009 Google Inc. All rights reserved.
  * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  *
  * This library is free software; you can redistribute it and/or
@@ skipping 2104 matching lines @@
         if (LocalFrame* frame = this->frame()) {
             // Cursor update scheduling is done by the local root, which is the main frame if there
             // are no RemoteFrame ancestors in the frame tree. Use of localFrameRoot() is
             // discouraged but will change when cursor update scheduling is moved from EventHandler
             // to PageEventHandler.
             frame->localFrameRoot()->eventHandler().scheduleCursorUpdate();
         }
     }
 }
 
-void LayoutObject::propagateStyleToAnonymousChildren(bool blockChildrenOnly)
+void LayoutObject::propagateStyleToAnonymousChildren()
 {
     // FIXME: We could save this call when the change only affected non-inherited properties.
     for (LayoutObject* child = slowFirstChild(); child; child = child->nextSibling()) {
         if (!child->isAnonymous() || child->style()->styleType() != PseudoIdNone)
             continue;
 
-        if (blockChildrenOnly && !child->isLayoutBlock())
-            continue;
-
-        if (child->isLayoutFullScreen() || child->isLayoutFullScreenPlaceholder())
+        if (child->anonymousHasStylePropagationOverride())

[mstensho (USE GERRIT), 2016/05/20 16:39:09]

Does anyone have a fancier name than this? :)

[eae, 2016/05/20 17:02:04]

While it doesn't exactly roll of the tongue it gets the message across.

             continue;
 
         RefPtr<ComputedStyle> newStyle = ComputedStyle::createAnonymousStyleWithDisplay(styleRef(), child->style()->display());
 
         // Preserve the position style of anonymous block continuations as they can have relative position when
         // they contain block descendants of relative positioned inlines.
-        if (child->isInFlowPositioned() && toLayoutBlock(child)->isAnonymousBlockContinuation())
+        if (child->isInFlowPositioned() && child->isLayoutBlock() && toLayoutBlock(child)->isAnonymousBlockContinuation())

[mstensho (USE GERRIT), 2016/05/20 16:39:09]

It only seems right to type-check here. Now more than ever. I'm pretty sure we
cannot have "in-flow" positioned (i.e. relative) anonymous non-blocks, but
still...

[eae, 2016/05/20 17:02:04]

Acknowledged.

             newStyle->setPosition(child->style()->position());
 
         updateAnonymousChildStyle(*child, *newStyle);
 
         child->setStyle(newStyle.release());
     }
 }
 
 void LayoutObject::setStyleWithWritingModeOfParent(PassRefPtr<ComputedStyle> style)
 {
@@ skipping 1536 matching lines @@
         const blink::LayoutObject* root = object1;
         while (root->parent())
             root = root->parent();
         root->showLayoutTreeAndMark(object1, "*", object2, "-", 0);
     } else {
         fprintf(stderr, "Cannot showLayoutTree. Root is (nil)\n");
     }
 }
 
 #endif