Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1037)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutBlock.cpp

Issue 2000683002: Keep writing-mode in sync between a column spanner and its placeholder. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: There should no longer be any need for LayoutTable to propagateStyleToAnonymousChildren(), since La… Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2007 David Smith (catfish.man@gmail.com) 4 * (C) 2007 David Smith (catfish.man@gmail.com)
5 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved. 5 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
6 * Copyright (C) Research In Motion Limited 2010. All rights reserved. 6 * Copyright (C) Research In Motion Limited 2010. All rights reserved.
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 211 matching lines...) Expand 10 before | Expand all | Expand 10 after
222 // in case containingBlock() changes by the change to the position p roperty. 222 // in case containingBlock() changes by the change to the position p roperty.
223 // See styleWillChange() for other cases. 223 // See styleWillChange() for other cases.
224 if (LayoutBlock* cb = containingBlock()) 224 if (LayoutBlock* cb = containingBlock())
225 cb->removePositionedObjects(this, NewContainingBlock); 225 cb->removePositionedObjects(this, NewContainingBlock);
226 } 226 }
227 } 227 }
228 228
229 if (TextAutosizer* textAutosizer = document().textAutosizer()) 229 if (TextAutosizer* textAutosizer = document().textAutosizer())
230 textAutosizer->record(this); 230 textAutosizer->record(this);
231 231
232 propagateStyleToAnonymousChildren(true); 232 propagateStyleToAnonymousChildren();
233 233
234 // It's possible for our border/padding to change, but for the overall logic al width or height of the block to 234 // It's possible for our border/padding to change, but for the overall logic al width or height of the block to
235 // end up being the same. We keep track of this change so in layoutBlock, we can know to set relayoutChildren=true. 235 // end up being the same. We keep track of this change so in layoutBlock, we can know to set relayoutChildren=true.
236 m_widthAvailableToChildrenChanged |= oldStyle && diff.needsFullLayout() && n eedsLayout() && borderOrPaddingLogicalDimensionChanged(*oldStyle, newStyle, Logi calWidth); 236 m_widthAvailableToChildrenChanged |= oldStyle && diff.needsFullLayout() && n eedsLayout() && borderOrPaddingLogicalDimensionChanged(*oldStyle, newStyle, Logi calWidth);
237 m_heightAvailableToChildrenChanged |= oldStyle && diff.needsFullLayout() && needsLayout() && borderOrPaddingLogicalDimensionChanged(*oldStyle, newStyle, Log icalHeight); 237 m_heightAvailableToChildrenChanged |= oldStyle && diff.needsFullLayout() && needsLayout() && borderOrPaddingLogicalDimensionChanged(*oldStyle, newStyle, Log icalHeight);
238 } 238 }
239 239
240 void LayoutBlock::updateFromStyle() 240 void LayoutBlock::updateFromStyle()
241 { 241 {
242 LayoutBox::updateFromStyle(); 242 LayoutBox::updateFromStyle();
(...skipping 1672 matching lines...) Expand 10 before | Expand all | Expand 10 after
1915 for (TrackedLayoutBoxListHashSet::const_iterator it = positionedDescenda ntSet->begin(); it != end; ++it) { 1915 for (TrackedLayoutBoxListHashSet::const_iterator it = positionedDescenda ntSet->begin(); it != end; ++it) {
1916 LayoutBox* currBox = *it; 1916 LayoutBox* currBox = *it;
1917 ASSERT(!currBox->needsLayout()); 1917 ASSERT(!currBox->needsLayout());
1918 } 1918 }
1919 } 1919 }
1920 } 1920 }
1921 1921
1922 #endif 1922 #endif
1923 1923
1924 } // namespace blink 1924 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698