Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutInline.cpp

Issue 2000683002: Keep writing-mode in sync between a column spanner and its placeholder. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: There should no longer be any need for LayoutTable to propagateStyleToAnonymousChildren(), since La… Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved. 4 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 178 matching lines...) Expand 10 before | Expand all | Expand 10 after
189 189
190 if (!alwaysCreateLineBoxes()) { 190 if (!alwaysCreateLineBoxes()) {
191 bool alwaysCreateLineBoxesNew = hasSelfPaintingLayer() || hasBoxDecorati onBackground() || newStyle.hasPadding() || newStyle.hasMargin() || newStyle.hasO utline(); 191 bool alwaysCreateLineBoxesNew = hasSelfPaintingLayer() || hasBoxDecorati onBackground() || newStyle.hasPadding() || newStyle.hasMargin() || newStyle.hasO utline();
192 if (oldStyle && alwaysCreateLineBoxesNew) { 192 if (oldStyle && alwaysCreateLineBoxesNew) {
193 dirtyLineBoxes(false); 193 dirtyLineBoxes(false);
194 setNeedsLayoutAndFullPaintInvalidation(LayoutInvalidationReason::Sty leChange); 194 setNeedsLayoutAndFullPaintInvalidation(LayoutInvalidationReason::Sty leChange);
195 } 195 }
196 setAlwaysCreateLineBoxes(alwaysCreateLineBoxesNew); 196 setAlwaysCreateLineBoxes(alwaysCreateLineBoxesNew);
197 } 197 }
198 198
199 propagateStyleToAnonymousChildren(true); 199 propagateStyleToAnonymousChildren();
200 } 200 }
201 201
202 void LayoutInline::updateAlwaysCreateLineBoxes(bool fullLayout) 202 void LayoutInline::updateAlwaysCreateLineBoxes(bool fullLayout)
203 { 203 {
204 // Once we have been tainted once, just assume it will happen again. This wa y effects like hover highlighting that change the 204 // Once we have been tainted once, just assume it will happen again. This wa y effects like hover highlighting that change the
205 // background color will only cause a layout on the first rollover. 205 // background color will only cause a layout on the first rollover.
206 if (alwaysCreateLineBoxes()) 206 if (alwaysCreateLineBoxes())
207 return; 207 return;
208 208
209 const ComputedStyle& parentStyle = parent()->styleRef(); 209 const ComputedStyle& parentStyle = parent()->styleRef();
(...skipping 1150 matching lines...) Expand 10 before | Expand all | Expand 10 after
1360 1360
1361 void LayoutInline::invalidateDisplayItemClients(const LayoutBoxModelObject& pain tInvalidationContainer, PaintInvalidationReason invalidationReason) const 1361 void LayoutInline::invalidateDisplayItemClients(const LayoutBoxModelObject& pain tInvalidationContainer, PaintInvalidationReason invalidationReason) const
1362 { 1362 {
1363 LayoutBoxModelObject::invalidateDisplayItemClients(paintInvalidationContaine r, invalidationReason); 1363 LayoutBoxModelObject::invalidateDisplayItemClients(paintInvalidationContaine r, invalidationReason);
1364 1364
1365 for (InlineFlowBox* box = firstLineBox(); box; box = box->nextLineBox()) 1365 for (InlineFlowBox* box = firstLineBox(); box; box = box->nextLineBox())
1366 paintInvalidationContainer.invalidateDisplayItemClientOnBacking(*box, in validationReason); 1366 paintInvalidationContainer.invalidateDisplayItemClientOnBacking(*box, in validationReason);
1367 } 1367 }
1368 1368
1369 } // namespace blink 1369 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698