Cleanup ConsoleMessage interface.

Cleanup ConsoleMessage interface.

Now that all places that need it collect call stack, we can remove redundant methods
on ConsoleMessage and introduce a few create() functions.

This also cleans up console message reporting a bit (FrameConsole and ConsoleMessageStorage).

BUG=611926
Committed: https://crrev.com/c76cb79e1aed30402db1f5cb598c382f42aafd05
Cr-Commit-Position: refs/heads/master@{#395216}

[dgozman, 2016-05-19 21:19:12]

dgozman@chromium.org changed reviewers:
+ kozyatinskiy@chromium.org, pfeldman@chromium.org

[dgozman, 2016-05-19 21:19:13]

Could you please take a look?

[kozy, 2016-05-19 21:46:30]

https://codereview.chromium.org/1999463002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/events/EventTarget.cpp (right):

https://codereview.chromium.org/1999463002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/events/EventTarget.cpp:105: message =
ConsoleMessage::create(JSMessageSource, WarningMessageLevel, messageText,
String(), function->GetScriptLineNumber() + 1,
function->GetScriptColumnNumber(), nullptr, function->ScriptId());
I think that it should be: function->GetScriptColumnNumber() + 1

https://codereview.chromium.org/1999463002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/FrameConsole.cpp (right):

https://codereview.chromium.org/1999463002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/FrameConsole.cpp:91: lineNumber =
consoleMessage->lineNumber();
Can we use it always?

https://codereview.chromium.org/1999463002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp (right):

https://codereview.chromium.org/1999463002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp:713: ConsoleMessage*
consoleMessage = ConsoleMessage::create(SecurityMessageSource,
ErrorMessageLevel, message, String(), 0, 0, stackTrace);
Before in setCallStack we set lineNumber, columnNumber and url from top call
frame. I think that it was good behavior.
Let's try to move it to async API.

[dgozman, 2016-05-19 22:57:14]

https://codereview.chromium.org/1999463002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/events/EventTarget.cpp (right):

https://codereview.chromium.org/1999463002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/events/EventTarget.cpp:105: message =
ConsoleMessage::create(JSMessageSource, WarningMessageLevel, messageText,
String(), function->GetScriptLineNumber() + 1,
function->GetScriptColumnNumber(), nullptr, function->ScriptId());
On 2016/05/19 21:46:29, kozyatinskiy wrote:
> I think that it should be: function->GetScriptColumnNumber() + 1

Done.

https://codereview.chromium.org/1999463002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/FrameConsole.cpp (right):

https://codereview.chromium.org/1999463002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/FrameConsole.cpp:91: lineNumber =
consoleMessage->lineNumber();
On 2016/05/19 21:46:29, kozyatinskiy wrote:
> Can we use it always?

Done.

https://codereview.chromium.org/1999463002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp (right):

https://codereview.chromium.org/1999463002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp:713: ConsoleMessage*
consoleMessage = ConsoleMessage::create(SecurityMessageSource,
ErrorMessageLevel, message, String(), 0, 0, stackTrace);
On 2016/05/19 21:46:29, kozyatinskiy wrote:
> Before in setCallStack we set lineNumber, columnNumber and url from top call
> frame. I think that it was good behavior.
Done.

> Let's try to move it to async API.
In a follow-up.

[kozy, 2016-05-19 23:07:49]

lgtm

[pfeldman, 2016-05-19 23:09:15]

lgtm

[dgozman, 2016-05-20 00:15:23]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2016-05-20 00:16:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1999463002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1999463002/20001

[commit-bot: I haz the power, 2016-05-20 01:03:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-20 01:03:45]

Try jobs failed on following builders:
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[dgozman, 2016-05-20 21:02:39]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2016-05-20 21:02:40]

The patchset sent to the CQ was uploaded after l-g-t-m from
kozyatinskiy@chromium.org, pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/1999463002/#ps40001
(title: "extensions fix")

[commit-bot: I haz the power, 2016-05-20 21:03:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1999463002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1999463002/40001

[commit-bot: I haz the power, 2016-05-20 22:59:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-20 22:59:50]

Try jobs failed on following builders:
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)

[dgozman, 2016-05-20 23:01:23]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2016-05-20 23:02:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1999463002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1999463002/40001

[dgozman, 2016-05-20 23:02:21]

The CQ bit was unchecked by dgozman@chromium.org

[dgozman, 2016-05-20 23:07:59]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2016-05-20 23:08:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
kozyatinskiy@chromium.org, pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/1999463002/#ps60001
(title: "PassRefPtr + win")

[commit-bot: I haz the power, 2016-05-20 23:08:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1999463002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1999463002/60001

[commit-bot: I haz the power, 2016-05-21 00:29:44]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-05-21 00:31:06]

Description was changed from

==========
Cleanup ConsoleMessage interface.

Now that all places that need it collect call stack, we can remove redundant
methods
on ConsoleMessage and introduce a few create() functions.

This also cleans up console message reporting a bit (FrameConsole and
ConsoleMessageStorage).

BUG=611926
==========

to

==========
Cleanup ConsoleMessage interface.

Now that all places that need it collect call stack, we can remove redundant
methods
on ConsoleMessage and introduce a few create() functions.

This also cleans up console message reporting a bit (FrameConsole and
ConsoleMessageStorage).

BUG=611926

Committed: https://crrev.com/c76cb79e1aed30402db1f5cb598c382f42aafd05
Cr-Commit-Position: refs/heads/master@{#395216}
==========

[commit-bot: I haz the power, 2016-05-21 00:31:08]

Patchset 4 (id:??) landed as
https://crrev.com/c76cb79e1aed30402db1f5cb598c382f42aafd05
Cr-Commit-Position: refs/heads/master@{#395216}