Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Unified Diff: third_party/WebKit/Source/core/frame/Deprecation.cpp

Issue 1999463002: Cleanup ConsoleMessage interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@console-message-callstack-in-constructor
Patch Set: PassRefPtr + win Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/Deprecation.cpp
diff --git a/third_party/WebKit/Source/core/frame/Deprecation.cpp b/third_party/WebKit/Source/core/frame/Deprecation.cpp
index f44a046d4a2433f492fe597fac32470c0bcf9424..1b25f4eb9ac3fe136d98af701c88e0f00f90cfba 100644
--- a/third_party/WebKit/Source/core/frame/Deprecation.cpp
+++ b/third_party/WebKit/Source/core/frame/Deprecation.cpp
@@ -99,7 +99,6 @@ void Deprecation::warnOnDeprecatedProperties(const LocalFrame* frame, CSSPropert
if (!message.isEmpty()) {
host->deprecation().suppress(unresolvedProperty);
ConsoleMessage* consoleMessage = ConsoleMessage::create(DeprecationMessageSource, WarningMessageLevel, message);
- consoleMessage->collectCallStack();
frame->console().addMessage(consoleMessage);
}
}
@@ -123,7 +122,6 @@ void Deprecation::countDeprecation(const LocalFrame* frame, UseCounter::Feature
host->useCounter().recordMeasurement(feature);
ASSERT(!deprecationMessage(feature).isEmpty());
ConsoleMessage* consoleMessage = ConsoleMessage::create(DeprecationMessageSource, WarningMessageLevel, deprecationMessage(feature));
- consoleMessage->collectCallStack();
frame->console().addMessage(consoleMessage);
}
}
« no previous file with comments | « third_party/WebKit/Source/core/events/EventTarget.cpp ('k') | third_party/WebKit/Source/core/frame/FrameConsole.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698