Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Side by Side Diff: third_party/WebKit/Source/core/dom/Document.cpp

Issue 1999463002: Cleanup ConsoleMessage interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@console-message-callstack-in-constructor
Patch Set: PassRefPtr + win Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org) 5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All r ights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All r ights reserved.
7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
8 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved. 8 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved.
9 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies) 9 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
10 * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved. 10 * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved.
(...skipping 2906 matching lines...) Expand 10 before | Expand all | Expand 10 after
2917 return &m_timers; 2917 return &m_timers;
2918 } 2918 }
2919 2919
2920 EventTarget* Document::errorEventTarget() 2920 EventTarget* Document::errorEventTarget()
2921 { 2921 {
2922 return domWindow(); 2922 return domWindow();
2923 } 2923 }
2924 2924
2925 void Document::logExceptionToConsole(const String& errorMessage, int scriptId, c onst String& sourceURL, int lineNumber, int columnNumber, PassRefPtr<ScriptCallS tack> callStack) 2925 void Document::logExceptionToConsole(const String& errorMessage, int scriptId, c onst String& sourceURL, int lineNumber, int columnNumber, PassRefPtr<ScriptCallS tack> callStack)
2926 { 2926 {
2927 ConsoleMessage* consoleMessage = ConsoleMessage::create(JSMessageSource, Err orMessageLevel, errorMessage, sourceURL, lineNumber, columnNumber); 2927 ConsoleMessage* consoleMessage = ConsoleMessage::create(JSMessageSource, Err orMessageLevel, errorMessage, sourceURL, lineNumber, columnNumber, callStack, sc riptId);
2928 consoleMessage->setScriptId(scriptId);
2929 consoleMessage->setCallStack(callStack);
2930 addConsoleMessage(consoleMessage); 2928 addConsoleMessage(consoleMessage);
2931 } 2929 }
2932 2930
2933 void Document::setURL(const KURL& url) 2931 void Document::setURL(const KURL& url)
2934 { 2932 {
2935 const KURL& newURL = url.isEmpty() ? blankURL() : url; 2933 const KURL& newURL = url.isEmpty() ? blankURL() : url;
2936 if (newURL == m_url) 2934 if (newURL == m_url)
2937 return; 2935 return;
2938 2936
2939 m_url = newURL; 2937 m_url = newURL;
(...skipping 3076 matching lines...) Expand 10 before | Expand all | Expand 10 after
6016 #ifndef NDEBUG 6014 #ifndef NDEBUG
6017 using namespace blink; 6015 using namespace blink;
6018 void showLiveDocumentInstances() 6016 void showLiveDocumentInstances()
6019 { 6017 {
6020 Document::WeakDocumentSet& set = Document::liveDocumentSet(); 6018 Document::WeakDocumentSet& set = Document::liveDocumentSet();
6021 fprintf(stderr, "There are %u documents currently alive:\n", set.size()); 6019 fprintf(stderr, "There are %u documents currently alive:\n", set.size());
6022 for (Document* document : set) 6020 for (Document* document : set)
6023 fprintf(stderr, "- Document %p URL: %s\n", document, document->url().get String().utf8().data()); 6021 fprintf(stderr, "- Document %p URL: %s\n", document, document->url().get String().utf8().data());
6024 } 6022 }
6025 #endif 6023 #endif
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp ('k') | third_party/WebKit/Source/core/events/EventTarget.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698