Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(960)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1998353003: Reduce ConsoleMessage API surface. (Closed)

Created:
4 years, 7 months ago by dgozman
Modified:
4 years, 7 months ago
Reviewers:
kozy, pfeldman
CC:
chromium-reviews, mkwst+watchlist-csp_chromium.org, caseq+blink_chromium.org, Nate Chapin, pfeldman+blink_chromium.org, sof, eae+blinkwatch, tyoshino+watch_chromium.org, lushnikov+blink_chromium.org, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews-bindings_chromium.org, gavinp+loader_chromium.org, devtools-reviews_chromium.org, blink-reviews, apavlov+blink_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org, loading-reviews_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@1999463002
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reduce ConsoleMessage API surface. BUG=611926 Committed: https://crrev.com/d35ba2cedab377ec22f5d4271a220a7deadca9a1 Cr-Commit-Position: refs/heads/master@{#395433}

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -111 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameConsole.cpp View 1 2 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/frame/csp/CSPDirectiveList.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/ConsoleMessage.h View 1 4 chunks +8 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/ConsoleMessage.cpp View 1 7 chunks +22 lines, -60 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.cpp View 1 3 chunks +6 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorResourceAgent.cpp View 1 2 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp View 1 2 chunks +2 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/loader/DocumentLoader.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoader.cpp View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
dgozman
Could you please take a look?
4 years, 7 months ago (2016-05-21 02:52:51 UTC) #2
pfeldman
lgtm
4 years, 7 months ago (2016-05-23 16:49:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1998353003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1998353003/20001
4 years, 7 months ago (2016-05-23 18:00:57 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-23 22:14:00 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-23 22:15:14 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/d35ba2cedab377ec22f5d4271a220a7deadca9a1
Cr-Commit-Position: refs/heads/master@{#395433}

Powered by Google App Engine
This is Rietveld 408576698