Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Side by Side Diff: third_party/WebKit/Source/core/events/EventTarget.cpp

Issue 1999463002: Cleanup ConsoleMessage interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@console-message-callstack-in-constructor
Patch Set: PassRefPtr + win Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved.
6 * Copyright (C) 2006 Alexey Proskuryakov (ap@webkit.org) 6 * Copyright (C) 2006 Alexey Proskuryakov (ap@webkit.org)
7 * (C) 2007, 2008 Nikolas Zimmermann <zimmermann@kde.org> 7 * (C) 2007, 2008 Nikolas Zimmermann <zimmermann@kde.org>
8 * 8 *
9 * Redistribution and use in source and binary forms, with or without 9 * Redistribution and use in source and binary forms, with or without
10 * modification, are permitted provided that the following conditions 10 * modification, are permitted provided that the following conditions
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
91 return; 91 return;
92 92
93 V8AbstractEventListener* v8Listener = V8AbstractEventListener::cast(register edListener->listener()); 93 V8AbstractEventListener* v8Listener = V8AbstractEventListener::cast(register edListener->listener());
94 v8::HandleScope handles(v8Listener->isolate()); 94 v8::HandleScope handles(v8Listener->isolate());
95 v8::Local<v8::Object> handler = v8Listener->getListenerObject(context); 95 v8::Local<v8::Object> handler = v8Listener->getListenerObject(context);
96 96
97 String messageText = String::format( 97 String messageText = String::format(
98 "Handling of '%s' input event was delayed for %ld ms due to main thread being busy. " 98 "Handling of '%s' input event was delayed for %ld ms due to main thread being busy. "
99 "Consider marking event handler as 'passive' to make the page more respo nive.", 99 "Consider marking event handler as 'passive' to make the page more respo nive.",
100 event->type().characters8(), lround(delayedSeconds * 1000)); 100 event->type().characters8(), lround(delayedSeconds * 1000));
101 ConsoleMessage* message = ConsoleMessage::create(JSMessageSource, WarningMes sageLevel, messageText); 101 ConsoleMessage* message = nullptr;
102 102
103 v8::Local<v8::Function> function = eventListenerEffectiveFunction(v8Listener ->isolate(), handler); 103 v8::Local<v8::Function> function = eventListenerEffectiveFunction(v8Listener ->isolate(), handler);
104 if (!function.IsEmpty()) { 104 if (!function.IsEmpty())
105 message->setLineNumber(function->GetScriptLineNumber() + 1); 105 message = ConsoleMessage::create(JSMessageSource, WarningMessageLevel, m essageText, String(), function->GetScriptLineNumber() + 1, function->GetScriptCo lumnNumber() + 1, nullptr, function->ScriptId());
106 message->setColumnNumber(function->GetScriptColumnNumber()); 106 else
107 message->setScriptId(function->ScriptId()); 107 message = ConsoleMessage::create(JSMessageSource, WarningMessageLevel, m essageText, String(), 0, 0);
108 }
109 context->addConsoleMessage(message); 108 context->addConsoleMessage(message);
110 registeredListener->setBlockedEventWarningEmitted(); 109 registeredListener->setBlockedEventWarningEmitted();
111 } 110 }
112 111
113 112
114 } // namespace 113 } // namespace
115 114
116 EventTargetData::EventTargetData() 115 EventTargetData::EventTargetData()
117 { 116 {
118 } 117 }
(...skipping 508 matching lines...) Expand 10 before | Expand all | Expand 10 after
627 // they have one less listener to invoke. 626 // they have one less listener to invoke.
628 if (d->firingEventIterators) { 627 if (d->firingEventIterators) {
629 for (size_t i = 0; i < d->firingEventIterators->size(); ++i) { 628 for (size_t i = 0; i < d->firingEventIterators->size(); ++i) {
630 d->firingEventIterators->at(i).iterator = 0; 629 d->firingEventIterators->at(i).iterator = 0;
631 d->firingEventIterators->at(i).end = 0; 630 d->firingEventIterators->at(i).end = 0;
632 } 631 }
633 } 632 }
634 } 633 }
635 634
636 } // namespace blink 635 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/dom/Document.cpp ('k') | third_party/WebKit/Source/core/frame/Deprecation.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698