Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(632)

Unified Diff: third_party/WebKit/Source/core/events/EventTarget.cpp

Issue 1999463002: Cleanup ConsoleMessage interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@console-message-callstack-in-constructor
Patch Set: PassRefPtr + win Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/events/EventTarget.cpp
diff --git a/third_party/WebKit/Source/core/events/EventTarget.cpp b/third_party/WebKit/Source/core/events/EventTarget.cpp
index e6dc72d4afcaddc30c272fc1e8f6ada3b5100e6b..4dfecb5ef90714c6229f9a9d0ff1af622bdb41db 100644
--- a/third_party/WebKit/Source/core/events/EventTarget.cpp
+++ b/third_party/WebKit/Source/core/events/EventTarget.cpp
@@ -98,14 +98,13 @@ void reportBlockedEvent(ExecutionContext* context, const Event* event, Registere
"Handling of '%s' input event was delayed for %ld ms due to main thread being busy. "
"Consider marking event handler as 'passive' to make the page more responive.",
event->type().characters8(), lround(delayedSeconds * 1000));
- ConsoleMessage* message = ConsoleMessage::create(JSMessageSource, WarningMessageLevel, messageText);
+ ConsoleMessage* message = nullptr;
v8::Local<v8::Function> function = eventListenerEffectiveFunction(v8Listener->isolate(), handler);
- if (!function.IsEmpty()) {
- message->setLineNumber(function->GetScriptLineNumber() + 1);
- message->setColumnNumber(function->GetScriptColumnNumber());
- message->setScriptId(function->ScriptId());
- }
+ if (!function.IsEmpty())
+ message = ConsoleMessage::create(JSMessageSource, WarningMessageLevel, messageText, String(), function->GetScriptLineNumber() + 1, function->GetScriptColumnNumber() + 1, nullptr, function->ScriptId());
+ else
+ message = ConsoleMessage::create(JSMessageSource, WarningMessageLevel, messageText, String(), 0, 0);
context->addConsoleMessage(message);
registeredListener->setBlockedEventWarningEmitted();
}
« no previous file with comments | « third_party/WebKit/Source/core/dom/Document.cpp ('k') | third_party/WebKit/Source/core/frame/Deprecation.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698