Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 1983953002: Replace uses of v8::Persistent with ScopedPersistent. (Closed)

Created:
4 years, 7 months ago by Ken Russell (switch to Gerrit)
Modified:
4 years, 7 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org, Zhenyao Mo, sof, jochen (gone - plz use gerrit)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace uses of v8::Persistent with ScopedPersistent. Copyable persistents have been mostly eliminated from the Blink code base, replaced with ScopedPersistent. Re-tested locally. BUG=608576 CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel Committed: https://crrev.com/3678e4df9b5256858d965ae8529dc7fb6b14647a Cr-Commit-Position: refs/heads/master@{#394024}

Patch Set 1 #

Messages

Total messages: 9 (4 generated)
Ken Russell (switch to Gerrit)
haraken: please review. zmo, others: FYI.
4 years, 7 months ago (2016-05-16 18:57:49 UTC) #3
haraken
LGTM
4 years, 7 months ago (2016-05-16 23:51:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1983953002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1983953002/1
4 years, 7 months ago (2016-05-17 00:25:56 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-17 02:30:00 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-17 02:31:49 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3678e4df9b5256858d965ae8529dc7fb6b14647a
Cr-Commit-Position: refs/heads/master@{#394024}

Powered by Google App Engine
This is Rietveld 408576698