third_party/WebKit/Source/modules/webgl/WebGLVertexArrayObjectBase.h - Issue 1983953002: Replace uses of v8::Persistent with ScopedPersistent.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGLVertexArrayObjectBase.h

Issue 1983953002: Replace uses of v8::Persistent with ScopedPersistent. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp ('k') | third_party/WebKit/Source/modules/webgl/WebGLVertexArrayObjectBase.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webgl/WebGLVertexArrayObjectBase.h

diff --git a/third_party/WebKit/Source/modules/webgl/WebGLVertexArrayObjectBase.h b/third_party/WebKit/Source/modules/webgl/WebGLVertexArrayObjectBase.h

index f2abff9bf9d699fb22651c0fc73c9b8d514503b3..bcf2d1b2ce804ec894bf4b07cdb4252f1025cfad 100644

--- a/third_party/WebKit/Source/modules/webgl/WebGLVertexArrayObjectBase.h

+++ b/third_party/WebKit/Source/modules/webgl/WebGLVertexArrayObjectBase.h

@@ -5,6 +5,7 @@

#ifndef WebGLVertexArrayObjectBase_h

#define WebGLVertexArrayObjectBase_h

+#include "bindings/core/v8/ScopedPersistent.h"

#include "modules/webgl/WebGLBuffer.h"

#include "modules/webgl/WebGLContextObject.h"

#include "platform/heap/Handle.h"

@@ -34,7 +35,7 @@ public:

void setArrayBufferForAttrib(GLuint, WebGLBuffer*);

void unbindBuffer(WebGLBuffer*);

- V8CopyablePersistent<v8::Array>* getPersistentCache();

+ ScopedPersistent<v8::Array>* getPersistentCache();

DECLARE_VIRTUAL_TRACE();

@@ -56,7 +57,7 @@ private:

// For preserving the wrappers of WebGLBuffer objects latched in

// via vertexAttribPointer calls.

- V8CopyablePersistent<v8::Array> m_arrayBufferWrappers;

+ ScopedPersistent<v8::Array> m_arrayBufferWrappers;

};

} // namespace blink