Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Side by Side Diff: third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.h

Issue 1983953002: Replace uses of v8::Persistent with ScopedPersistent. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Apple Inc. All rights reserved. 2 * Copyright (C) 2009 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
11 * documentation and/or other materials provided with the distribution. 11 * documentation and/or other materials provided with the distribution.
12 * 12 *
13 * THIS SOFTWARE IS PROVIDED BY APPLE COMPUTER, INC. ``AS IS'' AND ANY 13 * THIS SOFTWARE IS PROVIDED BY APPLE COMPUTER, INC. ``AS IS'' AND ANY
14 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE 14 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
15 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR 15 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
16 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE COMPUTER, INC. OR 16 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE COMPUTER, INC. OR
17 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, 17 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
18 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, 18 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
19 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR 19 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
20 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY 20 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
21 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 21 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
24 */ 24 */
25 25
26 #ifndef WebGLFramebuffer_h 26 #ifndef WebGLFramebuffer_h
27 #define WebGLFramebuffer_h 27 #define WebGLFramebuffer_h
28 28
29 #include "bindings/core/v8/ScopedPersistent.h"
29 #include "modules/webgl/WebGLContextObject.h" 30 #include "modules/webgl/WebGLContextObject.h"
30 #include "modules/webgl/WebGLSharedObject.h" 31 #include "modules/webgl/WebGLSharedObject.h"
31 32
32 namespace gpu { 33 namespace gpu {
33 namespace gles2 { 34 namespace gles2 {
34 class GLES2Interface; 35 class GLES2Interface;
35 } 36 }
36 } 37 }
37 38
38 namespace blink { 39 namespace blink {
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
87 88
88 // Wrapper for drawBuffersEXT/drawBuffersARB to work around a driver bug. 89 // Wrapper for drawBuffersEXT/drawBuffersARB to work around a driver bug.
89 void drawBuffers(const Vector<GLenum>& bufs); 90 void drawBuffers(const Vector<GLenum>& bufs);
90 91
91 GLenum getDrawBuffer(GLenum); 92 GLenum getDrawBuffer(GLenum);
92 93
93 void readBuffer(const GLenum colorBuffer) { m_readBuffer = colorBuffer; } 94 void readBuffer(const GLenum colorBuffer) { m_readBuffer = colorBuffer; }
94 95
95 GLenum getReadBuffer() const { return m_readBuffer; } 96 GLenum getReadBuffer() const { return m_readBuffer; }
96 97
97 V8CopyablePersistent<v8::Array>* getPersistentCache(); 98 ScopedPersistent<v8::Array>* getPersistentCache();
98 99
99 DECLARE_VIRTUAL_TRACE(); 100 DECLARE_VIRTUAL_TRACE();
100 101
101 protected: 102 protected:
102 explicit WebGLFramebuffer(WebGLRenderingContextBase*); 103 explicit WebGLFramebuffer(WebGLRenderingContextBase*);
103 104
104 bool hasObject() const override { return m_object != 0; } 105 bool hasObject() const override { return m_object != 0; }
105 void deleteObjectImpl(gpu::gles2::GLES2Interface*) override; 106 void deleteObjectImpl(gpu::gles2::GLES2Interface*) override;
106 107
107 private: 108 private:
(...skipping 15 matching lines...) Expand all
123 AttachmentMap m_attachments; 124 AttachmentMap m_attachments;
124 bool m_destructionInProgress; 125 bool m_destructionInProgress;
125 126
126 bool m_hasEverBeenBound; 127 bool m_hasEverBeenBound;
127 128
128 Vector<GLenum> m_drawBuffers; 129 Vector<GLenum> m_drawBuffers;
129 Vector<GLenum> m_filteredDrawBuffers; 130 Vector<GLenum> m_filteredDrawBuffers;
130 131
131 GLenum m_readBuffer; 132 GLenum m_readBuffer;
132 133
133 V8CopyablePersistent<v8::Array> m_attachmentWrappers; 134 ScopedPersistent<v8::Array> m_attachmentWrappers;
134 }; 135 };
135 136
136 } // namespace blink 137 } // namespace blink
137 138
138 #endif // WebGLFramebuffer_h 139 #endif // WebGLFramebuffer_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698