Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGLObject.h

Issue 1983953002: Replace uses of v8::Persistent with ScopedPersistent. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webgl/WebGLObject.h
diff --git a/third_party/WebKit/Source/modules/webgl/WebGLObject.h b/third_party/WebKit/Source/modules/webgl/WebGLObject.h
index 2a8011327db1f103dcd9d0c0ef8eaf7a069684cd..6fe0442298e365e767876869325286932dc2abce 100644
--- a/third_party/WebKit/Source/modules/webgl/WebGLObject.h
+++ b/third_party/WebKit/Source/modules/webgl/WebGLObject.h
@@ -56,18 +56,6 @@ GLuint objectNonZero(const T* object)
return result;
}
-// TODO(kbr): v8::Persistent doesn't auto-reset in its destructor,
-// which wreaks havoc when they're embedded in Oilpan objects even if
-// they use GarbageCollectedFinalized. The first V8 GC after the
-// Oilpan object is reclaimed will reset the cell in the
-// v8::Persistent, scribbling over the Oilpan heap. If v8::Persistents
-// are ever embedded in Oilpan objects, they must use
-// CopyablePersistentTraits to pick up the kResetInDestructor = true
-// setting. This alias template ensures correct usage, but ideally,
-// these persistent caches would not be necessary. crbug.com/611864
-template <typename T>
-using V8CopyablePersistent = v8::Persistent<T, v8::CopyablePersistentTraits<T>>;
-
class WebGLObject : public GarbageCollectedFinalized<WebGLObject>, public ScriptWrappable {
public:
virtual ~WebGLObject();
« no previous file with comments | « third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp ('k') | third_party/WebKit/Source/modules/webgl/WebGLProgram.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698