third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.h - Issue 1983953002: Replace uses of v8::Persistent with ScopedPersistent.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.h

Issue 1983953002: Replace uses of v8::Persistent with ScopedPersistent. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/ScopedPersistent.h ('k') | third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.h

diff --git a/third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.h b/third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.h

index b8ed8cc8d209de8e617b54cfe3626d96cb073e91..b068f8713ac9629091ce4a9bd65cf9d219388153 100644

--- a/third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.h

+++ b/third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.h

@@ -26,6 +26,7 @@

#ifndef WebGLFramebuffer_h

#define WebGLFramebuffer_h

+#include "bindings/core/v8/ScopedPersistent.h"

#include "modules/webgl/WebGLContextObject.h"

#include "modules/webgl/WebGLSharedObject.h"

@@ -94,7 +95,7 @@ public:

GLenum getReadBuffer() const { return m_readBuffer; }

- V8CopyablePersistent<v8::Array>* getPersistentCache();

+ ScopedPersistent<v8::Array>* getPersistentCache();

DECLARE_VIRTUAL_TRACE();

@@ -130,7 +131,7 @@ private:

GLenum m_readBuffer;

- V8CopyablePersistent<v8::Array> m_attachmentWrappers;

+ ScopedPersistent<v8::Array> m_attachmentWrappers;

};

} // namespace blink