Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1983783002: Remove OwnPtr::release() calls in modules/ (part 1). (Closed)

Created:
4 years, 7 months ago by Yuta Kitamura
Modified:
4 years, 7 months ago
Reviewers:
*haraken, *tzik
CC:
aboxhall, aboxhall+watch_chromium.org, ajuma+watch-canvas_chromium.org, blink-reviews, Rik, chromium-reviews, dmazzoni+watch_chromium.org, dmazzoni, dshwang, dtseng+watch_chromium.org, je_julie, Justin Novosad, nektar+watch_chromium.org, nektarios, yuzo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove OwnPtr::release() calls in modules/ (part 1). OwnPtr::release() calls can be (1) replaced with std::move(), or (2) removed entirely (in certain "return" statements). BUG=611660 Committed: https://crrev.com/3ad8f55720c66f440646d139b0fdeb78e2d6296b Cr-Commit-Position: refs/heads/master@{#393807}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+144 lines, -144 lines) Patch
M third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp View 6 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/InspectorTypeBuilderHelper.cpp View 6 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/modules/audio_output_devices/HTMLMediaElementAudioOutputDevice.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/cachestorage/InspectorCacheStorageAgent.cpp View 6 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp View 21 chunks +21 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/modules/compositorworker/CompositorWorkerGlobalScope.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThreadTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/crypto/NormalizeAlgorithm.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/Body.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/BodyStreamBufferTest.cpp View 9 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/CompositeDataConsumerHandle.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/CompositeDataConsumerHandleTest.cpp View 4 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/DataConsumerHandleTestUtil.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/DataConsumerHandleTestUtil.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/DataConsumerTee.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/DataConsumerTeeTest.cpp View 14 chunks +27 lines, -27 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/FetchBlobDataConsumerHandleTest.cpp View 5 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/FetchDataLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/FetchDataLoaderTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/FetchFormDataConsumerHandle.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/FetchFormDataConsumerHandleTest.cpp View 13 chunks +16 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/FetchRequestData.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/FetchResponseData.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/Request.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/Response.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/ResponseTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1983783002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1983783002/1
4 years, 7 months ago (2016-05-16 05:58:11 UTC) #2
Yuta Kitamura
tzik: PTAL? +haraken for modules/ approval.
4 years, 7 months ago (2016-05-16 06:00:44 UTC) #5
tzik
lgtm
4 years, 7 months ago (2016-05-16 06:03:09 UTC) #6
haraken
LGTM
4 years, 7 months ago (2016-05-16 06:28:49 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-16 07:24:07 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1983783002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1983783002/1
4 years, 7 months ago (2016-05-16 07:44:35 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-16 07:49:44 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-16 07:51:09 UTC) #14
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/3ad8f55720c66f440646d139b0fdeb78e2d6296b
Cr-Commit-Position: refs/heads/master@{#393807}

Powered by Google App Engine
This is Rietveld 408576698