Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Side by Side Diff: third_party/WebKit/Source/modules/fetch/ResponseTest.cpp

Issue 1983783002: Remove OwnPtr::release() calls in modules/ (part 1). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/modules/fetch/Response.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "modules/fetch/Response.h" 5 #include "modules/fetch/Response.h"
6 6
7 #include "bindings/core/v8/ExceptionState.h" 7 #include "bindings/core/v8/ExceptionState.h"
8 #include "bindings/core/v8/ScriptState.h" 8 #include "bindings/core/v8/ScriptState.h"
9 #include "core/dom/Document.h" 9 #include "core/dom/Document.h"
10 #include "core/frame/Frame.h" 10 #include "core/frame/Frame.h"
(...skipping 20 matching lines...) Expand all
31 const char* value; 31 const char* value;
32 } headers[] = { { "cache-control", "no-cache" }, { "set-cookie", "foop" }, { "foo", "bar" }, { 0, 0 } }; 32 } headers[] = { { "cache-control", "no-cache" }, { "set-cookie", "foop" }, { "foo", "bar" }, { 0, 0 } };
33 33
34 OwnPtr<WebServiceWorkerResponse> webResponse = adoptPtr(new WebServiceWorker Response()); 34 OwnPtr<WebServiceWorkerResponse> webResponse = adoptPtr(new WebServiceWorker Response());
35 webResponse->setURL(url); 35 webResponse->setURL(url);
36 webResponse->setStatus(status); 36 webResponse->setStatus(status);
37 webResponse->setStatusText(statusText); 37 webResponse->setStatusText(statusText);
38 webResponse->setResponseType(WebServiceWorkerResponseTypeDefault); 38 webResponse->setResponseType(WebServiceWorkerResponseTypeDefault);
39 for (int i = 0; headers[i].key; ++i) 39 for (int i = 0; headers[i].key; ++i)
40 webResponse->setHeader(WebString::fromUTF8(headers[i].key), WebString::f romUTF8(headers[i].value)); 40 webResponse->setHeader(WebString::fromUTF8(headers[i].key), WebString::f romUTF8(headers[i].value));
41 return webResponse.release(); 41 return webResponse;
42 } 42 }
43 43
44 class ServiceWorkerResponseTest : public ::testing::Test { 44 class ServiceWorkerResponseTest : public ::testing::Test {
45 public: 45 public:
46 ServiceWorkerResponseTest() 46 ServiceWorkerResponseTest()
47 : m_page(DummyPageHolder::create(IntSize(1, 1))) { } 47 : m_page(DummyPageHolder::create(IntSize(1, 1))) { }
48 48
49 ScriptState* getScriptState() { return ScriptState::forMainWorld(m_page->doc ument().frame()); } 49 ScriptState* getScriptState() { return ScriptState::forMainWorld(m_page->doc ument().frame()); }
50 ExecutionContext* getExecutionContext() { return getScriptState()->getExecut ionContext(); } 50 ExecutionContext* getExecutionContext() { return getScriptState()->getExecut ionContext(); }
51 51
(...skipping 132 matching lines...) Expand 10 before | Expand all | Expand 10 after
184 blink::testing::runPendingTasks(); 184 blink::testing::runPendingTasks();
185 } 185 }
186 186
187 BodyStreamBuffer* createHelloWorldBuffer(ScriptState* scriptState) 187 BodyStreamBuffer* createHelloWorldBuffer(ScriptState* scriptState)
188 { 188 {
189 using Command = DataConsumerHandleTestUtil::Command; 189 using Command = DataConsumerHandleTestUtil::Command;
190 OwnPtr<DataConsumerHandleTestUtil::ReplayingHandle> src(DataConsumerHandleTe stUtil::ReplayingHandle::create()); 190 OwnPtr<DataConsumerHandleTestUtil::ReplayingHandle> src(DataConsumerHandleTe stUtil::ReplayingHandle::create());
191 src->add(Command(Command::Data, "Hello, ")); 191 src->add(Command(Command::Data, "Hello, "));
192 src->add(Command(Command::Data, "world")); 192 src->add(Command(Command::Data, "world"));
193 src->add(Command(Command::Done)); 193 src->add(Command(Command::Done));
194 return new BodyStreamBuffer(scriptState, createFetchDataConsumerHandleFromWe bHandle(src.release())); 194 return new BodyStreamBuffer(scriptState, createFetchDataConsumerHandleFromWe bHandle(std::move(src)));
195 } 195 }
196 196
197 TEST_F(ServiceWorkerResponseTest, BodyStreamBufferCloneDefault) 197 TEST_F(ServiceWorkerResponseTest, BodyStreamBufferCloneDefault)
198 { 198 {
199 BodyStreamBuffer* buffer = createHelloWorldBuffer(getScriptState()); 199 BodyStreamBuffer* buffer = createHelloWorldBuffer(getScriptState());
200 FetchResponseData* fetchResponseData = FetchResponseData::createWithBuffer(b uffer); 200 FetchResponseData* fetchResponseData = FetchResponseData::createWithBuffer(b uffer);
201 fetchResponseData->setURL(KURL(ParsedURLString, "http://www.response.com")); 201 fetchResponseData->setURL(KURL(ParsedURLString, "http://www.response.com"));
202 Response* response = Response::create(getExecutionContext(), fetchResponseDa ta); 202 Response* response = Response::create(getExecutionContext(), fetchResponseDa ta);
203 EXPECT_EQ(response->internalBodyBuffer(), buffer); 203 EXPECT_EQ(response->internalBodyBuffer(), buffer);
204 checkResponseStream(getScriptState(), response, true); 204 checkResponseStream(getScriptState(), response, true);
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
252 EXPECT_CALL(*client1, didFetchDataLoadFailed()); 252 EXPECT_CALL(*client1, didFetchDataLoadFailed());
253 EXPECT_CALL(*client2, didFetchDataLoadFailed()); 253 EXPECT_CALL(*client2, didFetchDataLoadFailed());
254 254
255 response->internalBodyBuffer()->startLoading(FetchDataLoader::createLoaderAs String(), client1); 255 response->internalBodyBuffer()->startLoading(FetchDataLoader::createLoaderAs String(), client1);
256 clonedResponse->internalBodyBuffer()->startLoading(FetchDataLoader::createLo aderAsString(), client2); 256 clonedResponse->internalBodyBuffer()->startLoading(FetchDataLoader::createLo aderAsString(), client2);
257 blink::testing::runPendingTasks(); 257 blink::testing::runPendingTasks();
258 } 258 }
259 259
260 } // namespace 260 } // namespace
261 } // namespace blink 261 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/modules/fetch/Response.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698