third_party/WebKit/Source/modules/fetch/DataConsumerTee.cpp - Issue 1983783002: Remove OwnPtr::release() calls in modules/ (part 1).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/fetch/DataConsumerTee.cpp

Issue 1983783002: Remove OwnPtr::release() calls in modules/ (part 1). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/fetch/DataConsumerHandleTestUtil.cpp ('k') | third_party/WebKit/Source/modules/fetch/DataConsumerTeeTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/fetch/DataConsumerTee.cpp

diff --git a/third_party/WebKit/Source/modules/fetch/DataConsumerTee.cpp b/third_party/WebKit/Source/modules/fetch/DataConsumerTee.cpp

index 14aae5aaea75d27fc7d872688970917725027fc3..71f3deb798201e6ae325fdaeef45a0880540b6e9 100644

--- a/third_party/WebKit/Source/modules/fetch/DataConsumerTee.cpp

+++ b/third_party/WebKit/Source/modules/fetch/DataConsumerTee.cpp

@@ -150,7 +150,7 @@ public:

needsNotification = m_queue.isEmpty();

OwnPtr<Vector<char>> data = adoptPtr(new Vector<char>);

data->append(buffer, size);

- m_queue.append(data.release());

+ m_queue.append(std::move(data));

}

if (needsNotification)

notify();

@@ -425,8 +425,8 @@ void DataConsumerTee::create(ExecutionContext* executionContext, PassOwnPtr<Fetc

OwnPtr<WebDataConsumerHandle> webDest1, webDest2;

DataConsumerTee::create(executionContext, static_cast<PassOwnPtr<WebDataConsumerHandle>>(std::move(src)), &webDest1, &webDest2);

- *dest1 = createFetchDataConsumerHandleFromWebHandle(webDest1.release());

- *dest2 = createFetchDataConsumerHandleFromWebHandle(webDest2.release());

+ *dest1 = createFetchDataConsumerHandleFromWebHandle(std::move(webDest1));

+ *dest2 = createFetchDataConsumerHandleFromWebHandle(std::move(webDest2));

return;

}