Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(702)

Unified Diff: third_party/WebKit/Source/modules/fetch/FetchBlobDataConsumerHandleTest.cpp

Issue 1983783002: Remove OwnPtr::release() calls in modules/ (part 1). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/fetch/FetchBlobDataConsumerHandleTest.cpp
diff --git a/third_party/WebKit/Source/modules/fetch/FetchBlobDataConsumerHandleTest.cpp b/third_party/WebKit/Source/modules/fetch/FetchBlobDataConsumerHandleTest.cpp
index 759b52e04dce6e71324c051ae472a2d9bfebd5b2..869a72738fe7476ffb443af95cb5fd1e4a9bb783 100644
--- a/third_party/WebKit/Source/modules/fetch/FetchBlobDataConsumerHandleTest.cpp
+++ b/third_party/WebKit/Source/modules/fetch/FetchBlobDataConsumerHandleTest.cpp
@@ -65,7 +65,7 @@ PassRefPtr<BlobDataHandle> createBlobDataHandle(const char* s)
OwnPtr<BlobData> data = BlobData::create();
data->appendText(s, false);
auto size = data->length();
- return BlobDataHandle::create(data.release(), size);
+ return BlobDataHandle::create(std::move(data), size);
}
String toString(const Vector<char>& data)
@@ -236,8 +236,8 @@ TEST_F(FetchBlobDataConsumerHandleTest, ReadTest)
checkpoint.Call(1);
testing::runPendingTasks();
checkpoint.Call(2);
- client->didReceiveResponse(0, ResourceResponse(), src.release());
- HandleReaderRunner<HandleReader> runner(handle.release());
+ client->didReceiveResponse(0, ResourceResponse(), std::move(src));
+ HandleReaderRunner<HandleReader> runner(std::move(handle));
OwnPtr<HandleReadResult> r = runner.wait();
EXPECT_EQ(kDone, r->result());
EXPECT_EQ("hello, world", toString(r->data()));
@@ -275,8 +275,8 @@ TEST_F(FetchBlobDataConsumerHandleTest, TwoPhaseReadTest)
checkpoint.Call(1);
testing::runPendingTasks();
checkpoint.Call(2);
- client->didReceiveResponse(0, ResourceResponse(), src.release());
- HandleReaderRunner<HandleTwoPhaseReader> runner(handle.release());
+ client->didReceiveResponse(0, ResourceResponse(), std::move(src));
+ HandleReaderRunner<HandleTwoPhaseReader> runner(std::move(handle));
OwnPtr<HandleReadResult> r = runner.wait();
EXPECT_EQ(kDone, r->result());
EXPECT_EQ("hello, world", toString(r->data()));
@@ -307,7 +307,7 @@ TEST_F(FetchBlobDataConsumerHandleTest, LoadErrorTest)
testing::runPendingTasks();
checkpoint.Call(2);
client->didFail(ResourceError());
- HandleReaderRunner<HandleReader> runner(handle.release());
+ HandleReaderRunner<HandleReader> runner(std::move(handle));
OwnPtr<HandleReadResult> r = runner.wait();
EXPECT_EQ(kUnexpectedError, r->result());
}
@@ -342,8 +342,8 @@ TEST_F(FetchBlobDataConsumerHandleTest, BodyLoadErrorTest)
checkpoint.Call(1);
testing::runPendingTasks();
checkpoint.Call(2);
- client->didReceiveResponse(0, ResourceResponse(), src.release());
- HandleReaderRunner<HandleReader> runner(handle.release());
+ client->didReceiveResponse(0, ResourceResponse(), std::move(src));
+ HandleReaderRunner<HandleReader> runner(std::move(handle));
OwnPtr<HandleReadResult> r = runner.wait();
EXPECT_EQ(kUnexpectedError, r->result());
}

Powered by Google App Engine
This is Rietveld 408576698