third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp - Issue 1983783002: Remove OwnPtr::release() calls in modules/ (part 1).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp

Issue 1983783002: Remove OwnPtr::release() calls in modules/ (part 1). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/fetch/Body.cpp ('k') | third_party/WebKit/Source/modules/fetch/BodyStreamBufferTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp

diff --git a/third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp b/third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp

index 9eec54a24245ef5dd7d7b8f15eb97104eff97f15..24194dc9a4fd0609d1a729f05e1b49d5e7ddcf50 100644

--- a/third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp

+++ b/third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp

@@ -151,7 +151,7 @@ PassOwnPtr<FetchDataConsumerHandle> BodyStreamBuffer::releaseHandle()

// We need to call these before calling closeAndLockAndDisturb.

const bool isClosed = isStreamClosed();

const bool isErrored = isStreamErrored();

- OwnPtr<FetchDataConsumerHandle> handle = m_handle.release();

+ OwnPtr<FetchDataConsumerHandle> handle = std::move(m_handle);

closeAndLockAndDisturb();

@@ -164,7 +164,7 @@ PassOwnPtr<FetchDataConsumerHandle> BodyStreamBuffer::releaseHandle()

return createFetchDataConsumerHandleFromWebHandle(createUnexpectedErrorDataConsumerHandle());

ASSERT(handle);

- return handle.release();

+ return handle;

}

void BodyStreamBuffer::startLoading(FetchDataLoader* loader, FetchDataLoader::Client* client)