Remove OwnPtr::release() calls in modules/ (part 1).

third_party/WebKit/Source/modules/cachestorage/InspectorCacheStorageAgent.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "modules/cachestorage/InspectorCacheStorageAgent.h"
 #include "platform/heap/Handle.h"
 #include "platform/inspector_protocol/Dispatcher.h"
 #include "platform/inspector_protocol/TypeBuilder.h"
 #include "platform/inspector_protocol/Values.h"
 #include "platform/weborigin/KURL.h"
@@ skipping 60 matching lines @@
 
     // Cache Storage API is restricted to trustworthy origins.
     if (!secOrigin->isPotentiallyTrustworthy()) {
         *errorString = secOrigin->isPotentiallyTrustworthyErrorMessage();
         return nullptr;
     }
 
     OwnPtr<WebServiceWorkerCacheStorage> cache = adoptPtr(Platform::current()->cacheStorage(WebSecurityOrigin(secOrigin)));
     if (!cache)
         *errorString = "Could not find cache storage.";
-    return cache.release();
+    return cache;
 }
 
 PassOwnPtr<WebServiceWorkerCacheStorage> assertCacheStorageAndNameForId(ErrorString* errorString, const String& cacheId, String* cacheName)
 {
     String securityOrigin;
     if (!parseCacheId(errorString, cacheId, &securityOrigin, cacheName)) {
         return nullptr;
     }
     return assertCacheStorage(errorString, securityOrigin);
 }
@@ skipping 31 matching lines @@
 
     void onSuccess(const WebVector<WebString>& caches) override
     {
         OwnPtr<Array<Cache>> array = Array<Cache>::create();
         for (size_t i = 0; i < caches.size(); i++) {
             String name = String(caches[i]);
             OwnPtr<Cache> entry = Cache::create()
                 .setSecurityOrigin(m_securityOrigin)
                 .setCacheName(name)
                 .setCacheId(buildCacheId(m_securityOrigin, name)).build();
-            array->addItem(entry.release());
+            array->addItem(std::move(entry));
         }
-        m_callback->sendSuccess(array.release());
+        m_callback->sendSuccess(std::move(array));
     }
 
     void onError(WebServiceWorkerCacheError error) override
     {
         m_callback->sendFailure(String::format("Error requesting cache names: %s", serviceWorkerCacheErrorString(error).data()));
     }
 
 private:
     String m_securityOrigin;
     OwnPtr<RequestCacheNamesCallback> m_callback;
@@ skipping 48 matching lines @@
         bool hasMore = false;
         if (static_cast<size_t>(m_params.pageSize) < m_responses.size()) {
             m_responses.remove(m_params.pageSize, m_responses.size() - m_params.pageSize);
             hasMore = true;
         }
         OwnPtr<Array<DataEntry>> array = Array<DataEntry>::create();
         for (const auto& requestResponse : m_responses) {
             OwnPtr<DataEntry> entry = DataEntry::create()
                 .setRequest(requestResponse.request)
                 .setResponse(requestResponse.response).build();
-            array->addItem(entry.release());
+            array->addItem(std::move(entry));
         }
-        m_callback->sendSuccess(array.release(), hasMore);
+        m_callback->sendSuccess(std::move(array), hasMore);
     }
 
     void sendFailure(const String& error)
     {
         m_callback->sendFailure(error);
     }
 
 private:
     DataRequestParams m_params;
     int m_numResponsesLeft;
@@ skipping 39 matching lines @@
         , m_callback(std::move(callback))
     {
     }
     ~GetCacheKeysForRequestData() override { }
 
     WebServiceWorkerCache* cache() { return m_cache.get(); }
     void onSuccess(const WebVector<WebServiceWorkerRequest>& requests) override
     {
         if (requests.isEmpty()) {
             OwnPtr<Array<DataEntry>> array = Array<DataEntry>::create();
-            m_callback->sendSuccess(array.release(), false);
+            m_callback->sendSuccess(std::move(array), false);
             return;
         }
-        RefPtr<ResponsesAccumulator> accumulator = adoptRef(new ResponsesAccumulator(requests.size(), m_params, m_callback.release()));
+        RefPtr<ResponsesAccumulator> accumulator = adoptRef(new ResponsesAccumulator(requests.size(), m_params, std::move(m_callback)));
 
         for (size_t i = 0; i < requests.size(); i++) {
             const auto& request = requests[i];
             auto* cacheRequest = new GetCacheResponsesForRequestData(m_params, request, accumulator);
             m_cache->dispatchMatch(cacheRequest, request, WebServiceWorkerCache::QueryParams());
         }
     }
 
     void onError(WebServiceWorkerCacheError error) override
     {
@@ skipping 13 matching lines @@
 public:
     GetCacheForRequestData(const DataRequestParams& params, PassOwnPtr<RequestEntriesCallback> callback)
         : m_params(params)
         , m_callback(std::move(callback))
     {
     }
     ~GetCacheForRequestData() override { }
 
     void onSuccess(std::unique_ptr<WebServiceWorkerCache> cache) override
     {
-        auto* cacheRequest = new GetCacheKeysForRequestData(m_params, adoptPtr(cache.release()), m_callback.release());
+        auto* cacheRequest = new GetCacheKeysForRequestData(m_params, adoptPtr(cache.release()), std::move(m_callback));
         cacheRequest->cache()->dispatchKeys(cacheRequest, nullptr, WebServiceWorkerCache::QueryParams());
     }
 
     void onError(WebServiceWorkerCacheError error) override
     {
         m_callback->sendFailure(String::format("Error requesting cache %s: %s", m_params.cacheName.utf8().data(), serviceWorkerCacheErrorString(error).data()));
     }
 
 private:
     DataRequestParams m_params;
@@ skipping 56 matching lines @@
     GetCacheForDeleteEntry(const String& requestSpec, const String& cacheName, PassOwnPtr<DeleteEntryCallback> callback)
         : m_requestSpec(requestSpec)
         , m_cacheName(cacheName)
         , m_callback(std::move(callback))
     {
     }
     ~GetCacheForDeleteEntry() override { }
 
     void onSuccess(std::unique_ptr<WebServiceWorkerCache> cache) override
     {
-        auto* deleteRequest = new DeleteCacheEntry(m_callback.release());
+        auto* deleteRequest = new DeleteCacheEntry(std::move(m_callback));
         BatchOperation deleteOperation;
         deleteOperation.operationType = WebServiceWorkerCache::OperationTypeDelete;
         deleteOperation.request.setURL(KURL(ParsedURLString, m_requestSpec));
         Vector<BatchOperation> operations;
         operations.append(deleteOperation);
         cache.release()->dispatchBatch(deleteRequest, WebVector<BatchOperation>(operations));
     }
 
     void onError(WebServiceWorkerCacheError error) override
     {
@@ skipping 71 matching lines @@
     OwnPtr<WebServiceWorkerCacheStorage> cache = assertCacheStorageAndNameForId(errorString, cacheId, &cacheName);
     if (!cache) {
         callback->sendFailure(*errorString);
         return;
     }
     cache->dispatchOpen(new GetCacheForDeleteEntry(request, cacheName, std::move(callback)), WebString(cacheName));
 }
 
 
 } // namespace blink