Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issue 198163004: Revert 257524 "Move IsStringASCII/UTF8 to base namespace." (Closed)

Created:
6 years, 9 months ago by brettw
Modified:
6 years, 9 months ago
Reviewers:
brettw
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 257524 "Move IsStringASCII/UTF8 to base namespace." > Move IsStringASCII/UTF8 to base namespace. > > Use StringPiece for IsStringUTF8. > > TBR=sky > > Review URL: https://codereview.chromium.org/196793010 TBR=brettw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257533

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -142 lines) Patch
M trunk/src/base/command_line.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M trunk/src/base/i18n/streaming_utf8_validator_perftest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M trunk/src/base/strings/string_util.h View 2 chunks +13 lines, -13 lines 0 comments Download
M trunk/src/base/strings/string_util.cc View 3 chunks +15 lines, -15 lines 0 comments Download
M trunk/src/chrome/app/chrome_main_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/bookmarks/bookmark_codec.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/bookmarks/bookmark_html_writer.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/chromeos/drive/file_system_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/chromeos/system/syslogs_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/download/download_extensions.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/extensions/api/cookies/cookies_helpers.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/extensions/api/proxy/proxy_api_helpers.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M trunk/src/chrome/browser/extensions/api/serial/serial_connection.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/extensions/api/web_request/web_request_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/extensions/convert_user_script.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/extensions/extension_protocols.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/internal_auth.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M trunk/src/chrome/browser/invalidation/invalidator_storage_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/net/firefox_proxy_settings.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/profile_resetter/jtl_interpreter.cc View 10 chunks +13 lines, -13 lines 0 comments Download
M trunk/src/chrome/browser/spellchecker/spellcheck_custom_dictionary.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/sync_file_system/drive_backend_v1/api_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/ui/webui/net_internals/net_internals_ui.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M trunk/src/chrome/common/extensions/extension_file_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/common/extensions/manifest_handlers/content_scripts_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/common/net/url_fixer_upper.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/chrome/installer/util/installer_state.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chromeos/network/shill_property_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/components/autofill/content/browser/wallet/wallet_address.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/components/autofill/core/browser/address.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/components/autofill/core/browser/validation.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/components/storage_monitor/portable_device_watcher_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/components/url_matcher/url_matcher_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M trunk/src/content/browser/browser_plugin/browser_plugin_guest_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/browser/indexed_db/indexed_db_backing_store.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/browser/storage_partition_impl_map.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/browser/webui/web_ui_impl.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M trunk/src/content/child/ftp_directory_listing_response_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/child/simple_webmimeregistry_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download
M trunk/src/content/renderer/media/android/webmediaplayer_android.cc View 1 chunk +1 line, -2 lines 0 comments Download
M trunk/src/content/renderer/media/webcontentdecryptionmodule_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/renderer/media/webcontentdecryptionmodulesession_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/renderer/media/webmediaplayer_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download
M trunk/src/content/renderer/pepper/content_renderer_pepper_host_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/renderer/renderer_webkitplatformsupport_impl.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M trunk/src/dbus/message.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/jingle/notifier/listener/notification_defines_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/media/cdm/json_web_key.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/net/base/mime_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/net/base/net_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/net/base/net_util_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/net/dns/dns_config_service_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/net/ftp/ftp_network_transaction.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/net/http/http_content_disposition.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M trunk/src/net/proxy/proxy_resolver_v8.cc View 8 chunks +9 lines, -9 lines 0 comments Download
M trunk/src/ppapi/shared_impl/dictionary_var.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/ppapi/shared_impl/file_ref_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/ppapi/shared_impl/var.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/remoting/protocol/me2me_host_authenticator_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/sync/util/cryptographer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/ui/base/l10n/l10n_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/webkit/common/database/database_identifier.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
brettw
6 years, 9 months ago (2014-03-17 23:53:35 UTC) #1
brettw
6 years, 9 months ago (2014-03-17 23:55:47 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r257533 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698