Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: trunk/src/components/url_matcher/url_matcher_unittest.cc

Issue 198163004: Revert 257524 "Move IsStringASCII/UTF8 to base namespace." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/components/storage_monitor/portable_device_watcher_win.cc ('k') | trunk/src/content/browser/browser_plugin/browser_plugin_guest_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/components/url_matcher/url_matcher_unittest.cc
===================================================================
--- trunk/src/components/url_matcher/url_matcher_unittest.cc (revision 257532)
+++ trunk/src/components/url_matcher/url_matcher_unittest.cc (working copy)
@@ -159,10 +159,10 @@
// non ASCII-7 characters. We test this here, because a change to this
// guarantee breaks this implementation horribly.
GURL url("http://www.föö.com/föö?föö#föö");
- EXPECT_TRUE(base::IsStringASCII(url.host()));
- EXPECT_TRUE(base::IsStringASCII(url.path()));
- EXPECT_TRUE(base::IsStringASCII(url.query()));
- EXPECT_FALSE(base::IsStringASCII(url.ref()));
+ EXPECT_TRUE(IsStringASCII(url.host()));
+ EXPECT_TRUE(IsStringASCII(url.path()));
+ EXPECT_TRUE(IsStringASCII(url.query()));
+ EXPECT_FALSE(IsStringASCII(url.ref()));
}
TEST(URLMatcherConditionFactoryTest, Criteria) {
« no previous file with comments | « trunk/src/components/storage_monitor/portable_device_watcher_win.cc ('k') | trunk/src/content/browser/browser_plugin/browser_plugin_guest_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698