trunk/src/chrome/browser/extensions/api/cookies/cookies_helpers.cc - Issue 198163004: Revert 257524 "Move IsStringASCII/UTF8 to base namespace."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: trunk/src/chrome/browser/extensions/api/cookies/cookies_helpers.cc

Issue 198163004: Revert 257524 "Move IsStringASCII/UTF8 to base namespace." (Closed) Base URL: svn://svn.chromium.org/chrome/

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: trunk/src/chrome/browser/extensions/api/cookies/cookies_helpers.cc

===================================================================

--- trunk/src/chrome/browser/extensions/api/cookies/cookies_helpers.cc (revision 257532)

+++ trunk/src/chrome/browser/extensions/api/cookies/cookies_helpers.cc (working copy)

@@ -76,8 +76,8 @@

cookie->host_only = net::cookie_util::DomainIsHostOnly(

canonical_cookie.Domain());

// A non-UTF8 path is invalid, so we just replace it with an empty string.

- cookie->path = base::IsStringUTF8(canonical_cookie.Path())

- ? canonical_cookie.Path() : std::string();

+ cookie->path = IsStringUTF8(canonical_cookie.Path()) ? canonical_cookie.Path()

+ : std::string();

cookie->secure = canonical_cookie.IsSecure();

cookie->http_only = canonical_cookie.IsHttpOnly();

cookie->session = !canonical_cookie.IsPersistent();