Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Unified Diff: trunk/src/chrome/browser/ui/webui/net_internals/net_internals_ui.cc

Issue 198163004: Revert 257524 "Move IsStringASCII/UTF8 to base namespace." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/chrome/browser/ui/webui/net_internals/net_internals_ui.cc
===================================================================
--- trunk/src/chrome/browser/ui/webui/net_internals/net_internals_ui.cc (revision 257532)
+++ trunk/src/chrome/browser/ui/webui/net_internals/net_internals_ui.cc (working copy)
@@ -1220,7 +1220,7 @@
CHECK(list->GetString(0, &domain));
base::DictionaryValue* result = new base::DictionaryValue();
- if (!base::IsStringASCII(domain)) {
+ if (!IsStringASCII(domain)) {
result->SetString("error", "non-ASCII domain name");
} else {
net::TransportSecurityState* transport_security_state =
@@ -1261,7 +1261,7 @@
// include subdomains>, <key pins>].
std::string domain;
CHECK(list->GetString(0, &domain));
- if (!base::IsStringASCII(domain)) {
+ if (!IsStringASCII(domain)) {
// Silently fail. The user will get a helpful error if they query for the
// name.
return;
@@ -1295,7 +1295,7 @@
// |list| should be: [<domain to query>].
std::string domain;
CHECK(list->GetString(0, &domain));
- if (!base::IsStringASCII(domain)) {
+ if (!IsStringASCII(domain)) {
// There cannot be a unicode entry in the HSTS set.
return;
}

Powered by Google App Engine
This is Rietveld 408576698