Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1153)

Unified Diff: trunk/src/base/command_line.cc

Issue 198163004: Revert 257524 "Move IsStringASCII/UTF8 to base namespace." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | trunk/src/base/i18n/streaming_utf8_validator_perftest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/base/command_line.cc
===================================================================
--- trunk/src/base/command_line.cc (revision 257532)
+++ trunk/src/base/command_line.cc (working copy)
@@ -305,7 +305,7 @@
std::string CommandLine::GetSwitchValueASCII(
const std::string& switch_string) const {
StringType value = GetSwitchValueNative(switch_string);
- if (!base::IsStringASCII(value)) {
+ if (!IsStringASCII(value)) {
DLOG(WARNING) << "Value of switch (" << switch_string << ") must be ASCII.";
return std::string();
}
@@ -387,8 +387,8 @@
void CommandLine::AppendArg(const std::string& value) {
#if defined(OS_WIN)
- DCHECK(base::IsStringUTF8(value));
- AppendArgNative(base::UTF8ToWide(value));
+ DCHECK(IsStringUTF8(value));
+ AppendArgNative(UTF8ToWide(value));
#elif defined(OS_POSIX)
AppendArgNative(value);
#endif
« no previous file with comments | « no previous file | trunk/src/base/i18n/streaming_utf8_validator_perftest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698