Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 196793010: Move IsStringASCII/UTF8 to base namespace. (Closed)

Created:
6 years, 9 months ago by brettw
Modified:
6 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, asanka, nkostylev+watch_chromium.org, tzik, alecflett, rpetterson, browser-components-watch_chromium.org, ericu+idb_chromium.org, dgrogan, kinuko+watch, stevenjb+watch_chromium.org, tim+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, benjhayden+dwatch_chromium.org, grt+watch_chromium.org, chromoting-reviews_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, groby+spellwatch_chromium.org, chromium-apps-reviews_chromium.org, erikwright+watch_chromium.org, Dane Wallinga, cmumford, fischman+watch_chromium.org, haitaol+watch_chromium.org, rouslan+spellwatch_chromium.org, nhiroki, feature-media-reviews_chromium.org, oshima+watch_chromium.org, jsbell+idb_chromium.org, rouslan+autofillwatch_chromium.org, maniscalco+watch_chromium.org, Ilya Sherman, tfarina, mcasas+watch_chromium.org, benquan, eroman, mmenke, dyu1, Paweł Hajdan Jr., estade+watch_chromium.org, wjia+watch_chromium.org, jshin+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Move IsStringASCII/UTF8 to base namespace. Use StringPiece for IsStringUTF8. TBR=sky Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257524

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : perf test #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -134 lines) Patch
M base/command_line.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/i18n/streaming_utf8_validator_perftest.cc View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M base/strings/string_util.h View 1 2 chunks +13 lines, -13 lines 0 comments Download
M base/strings/string_util.cc View 1 3 chunks +15 lines, -15 lines 0 comments Download
M chrome/app/chrome_main_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_codec.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_html_writer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_system_util.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/system/syslogs_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_extensions.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/cookies/cookies_helpers.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/proxy/proxy_api_helpers.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/serial/serial_connection.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_api.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/convert_user_script.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_protocols.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/internal_auth.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/invalidation/invalidator_storage_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/firefox_proxy_settings.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profile_resetter/jtl_interpreter.cc View 10 chunks +13 lines, -13 lines 0 comments Download
M chrome/browser/spellchecker/spellcheck_custom_dictionary.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend_v1/api_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/net_internals/net_internals_ui.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/extension_file_util.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/manifest_handlers/content_scripts_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/net/url_fixer_upper.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/installer/util/installer_state.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/shill_property_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/content/browser/wallet/wallet_address.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/address.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/autofill/core/browser/validation.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/storage_monitor/portable_device_watcher_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/url_matcher/url_matcher_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_guest_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_backing_store.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/storage_partition_impl_map.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/webui/web_ui_impl.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M content/child/ftp_directory_listing_response_delegate.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M content/child/simple_webmimeregistry_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/media/android/webmediaplayer_android.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/media/webcontentdecryptionmodule_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/webcontentdecryptionmodulesession_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/webmediaplayer_impl.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/pepper/content_renderer_pepper_host_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M dbus/message.cc View 1 chunk +1 line, -1 line 0 comments Download
M jingle/notifier/listener/notification_defines_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/cdm/json_web_key.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/base/mime_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/base/net_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/base/net_util_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/dns/dns_config_service_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/ftp/ftp_network_transaction.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/http/http_content_disposition.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M net/proxy/proxy_resolver_v8.cc View 8 chunks +9 lines, -9 lines 0 comments Download
M ppapi/shared_impl/dictionary_var.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/shared_impl/file_ref_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/shared_impl/var.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/me2me_host_authenticator_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/util/cryptographer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/l10n/l10n_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/common/database/database_identifier.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
brettw
6 years, 9 months ago (2014-03-14 21:45:29 UTC) #1
brettw
6 years, 9 months ago (2014-03-17 23:14:06 UTC) #2
Message was sent while issue was closed. 
Committed patchset #7 manually as r257524 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698