Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(612)

Issue 19737005: Revert 212948 "Made MessagePump a non-thread safe class." (Closed)

Created:
7 years, 5 months ago by alexeypa (please no reviews)
Modified:
7 years, 5 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 212948 "Made MessagePump a non-thread safe class." r212948 broke Mac Builder: http://build.chromium.org/p/chromium.memory/builders/Mac%20ASAN%20Builder/builds/25623 > Made MessagePump a non-thread safe class. > > This CL makes MessagePump a non-thread safe class to make sure thread-bound resources (such as the UI window used for pumping messages on Windows) are freed on the correct thread. > > Handling of incoming tasks and synchronization between different threads was moved out to a separate class - IncomingTaskQueue reducing the number of locks to be taken while posting a task to one. Posting tasks via both MessageLoop and MessageLoopProxyImpl is now routed via IncomingTaskQueue. > > BUG=241939 > > Review URL: https://chromiumcodereview.appspot.com/17567007 TBR=alexeypa@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=212952

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+405 lines, -490 lines) Patch
M trunk/src/base/base.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
D trunk/src/base/message_loop/incoming_task_queue.h View 1 chunk +0 lines, -104 lines 0 comments Download
D trunk/src/base/message_loop/incoming_task_queue.cc View 1 chunk +0 lines, -169 lines 0 comments Download
M trunk/src/base/message_loop/message_loop.h View 8 chunks +61 lines, -42 lines 0 comments Download
M trunk/src/base/message_loop/message_loop.cc View 13 chunks +150 lines, -51 lines 0 comments Download
M trunk/src/base/message_loop/message_loop_proxy_impl.h View 2 chunks +25 lines, -16 lines 0 comments Download
M trunk/src/base/message_loop/message_loop_proxy_impl.cc View 1 chunk +53 lines, -15 lines 0 comments Download
M trunk/src/base/message_loop/message_loop_unittest.cc View 5 chunks +21 lines, -9 lines 0 comments Download
M trunk/src/base/message_loop/message_pump.h View 3 chunks +6 lines, -3 lines 0 comments Download
M trunk/src/base/message_loop/message_pump_android.h View 2 chunks +3 lines, -1 line 0 comments Download
M trunk/src/base/message_loop/message_pump_aurax11.h View 2 chunks +3 lines, -1 line 0 comments Download
M trunk/src/base/message_loop/message_pump_aurax11.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M trunk/src/base/message_loop/message_pump_default.h View 2 chunks +3 lines, -1 line 0 comments Download
M trunk/src/base/message_loop/message_pump_default.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M trunk/src/base/message_loop/message_pump_glib.h View 2 chunks +2 lines, -1 line 0 comments Download
M trunk/src/base/message_loop/message_pump_glib.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M trunk/src/base/message_loop/message_pump_gtk.h View 2 chunks +3 lines, -1 line 0 comments Download
M trunk/src/base/message_loop/message_pump_gtk.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M trunk/src/base/message_loop/message_pump_io_ios.h View 6 chunks +6 lines, -7 lines 0 comments Download
M trunk/src/base/message_loop/message_pump_io_ios.cc View 5 chunks +6 lines, -7 lines 0 comments Download
M trunk/src/base/message_loop/message_pump_io_ios_unittest.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M trunk/src/base/message_loop/message_pump_libevent.h View 2 chunks +3 lines, -1 line 0 comments Download
M trunk/src/base/message_loop/message_pump_libevent_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/base/message_loop/message_pump_mac.h View 8 chunks +16 lines, -6 lines 0 comments Download
M trunk/src/base/message_loop/message_pump_mac.mm View 1 chunk +0 lines, -3 lines 0 comments Download
M trunk/src/base/message_loop/message_pump_ozone.h View 2 chunks +1 line, -1 line 0 comments Download
M trunk/src/base/test/test_support_android.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/ui/cocoa/browser/avatar_menu_bubble_controller_unittest.mm View 3 chunks +3 lines, -4 lines 0 comments Download
MM trunk/src/chrome/browser/ui/cocoa/constrained_window/constrained_window_animation_unittest.mm View 3 chunks +2 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/ui/cocoa/history_overlay_controller_unittest.mm View 3 chunks +3 lines, -4 lines 0 comments Download
M trunk/src/chrome/browser/ui/cocoa/run_loop_testing.mm View 2 chunks +1 line, -2 lines 0 comments Download
M trunk/src/media/base/pipeline_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/net/dns/dns_transaction_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/net/dns/serial_worker_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
alexeypa (please no reviews)
7 years, 5 months ago (2013-07-22 20:06:37 UTC) #1
alexeypa (please no reviews)
7 years, 5 months ago (2013-07-22 20:06:58 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r212952.

Powered by Google App Engine
This is Rietveld 408576698