Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Unified Diff: trunk/src/base/message_loop/message_pump_io_ios_unittest.cc

Issue 19737005: Revert 212948 "Made MessagePump a non-thread safe class." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/base/message_loop/message_pump_io_ios_unittest.cc
===================================================================
--- trunk/src/base/message_loop/message_pump_io_ios_unittest.cc (revision 212951)
+++ trunk/src/base/message_loop/message_pump_io_ios_unittest.cc (working copy)
@@ -126,7 +126,7 @@
};
TEST_F(MessagePumpIOSForIOTest, DeleteWatcher) {
- scoped_ptr<MessagePumpIOSForIO> pump(new MessagePumpIOSForIO);
+ scoped_refptr<MessagePumpIOSForIO> pump(new MessagePumpIOSForIO);
MessagePumpIOSForIO::FileDescriptorWatcher* watcher =
new MessagePumpIOSForIO::FileDescriptorWatcher;
DeleteWatcher delegate(watcher);
@@ -162,9 +162,9 @@
};
TEST_F(MessagePumpIOSForIOTest, StopWatcher) {
- scoped_ptr<MessagePumpIOSForIO> pump(new MessagePumpIOSForIO);
+ scoped_refptr<MessagePumpIOSForIO> pump(new MessagePumpIOSForIO);
MessagePumpIOSForIO::FileDescriptorWatcher watcher;
- StopWatcher delegate(&watcher, pump.get());
+ StopWatcher delegate(&watcher, pump);
pump->WatchFileDescriptor(pipefds_[1],
false, MessagePumpIOSForIO::WATCH_READ_WRITE, &watcher, &delegate);
@@ -173,9 +173,9 @@
}
TEST_F(MessagePumpIOSForIOTest, StopWatcherAndWatchSomethingElse) {
- scoped_ptr<MessagePumpIOSForIO> pump(new MessagePumpIOSForIO);
+ scoped_refptr<MessagePumpIOSForIO> pump(new MessagePumpIOSForIO);
MessagePumpIOSForIO::FileDescriptorWatcher watcher;
- StopWatcher delegate(&watcher, pump.get(), alternate_pipefds_[1]);
+ StopWatcher delegate(&watcher, pump, alternate_pipefds_[1]);
pump->WatchFileDescriptor(pipefds_[1],
false, MessagePumpIOSForIO::WATCH_READ_WRITE, &watcher, &delegate);
« no previous file with comments | « trunk/src/base/message_loop/message_pump_io_ios.cc ('k') | trunk/src/base/message_loop/message_pump_libevent.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698