Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: trunk/src/base/test/test_support_android.cc

Issue 19737005: Revert 212948 "Made MessagePump a non-thread safe class." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/base/test/test_support_android.cc
===================================================================
--- trunk/src/base/test/test_support_android.cc (revision 212951)
+++ trunk/src/base/test/test_support_android.cc (working copy)
@@ -72,8 +72,6 @@
// The MessagePumpForUI implementation for test purpose.
class MessagePumpForUIStub : public base::MessagePumpForUI {
- virtual ~MessagePumpForUIStub() {}
-
virtual void Start(base::MessagePump::Delegate* delegate) OVERRIDE {
NOTREACHED() << "The Start() method shouldn't be called in test, using"
" Run() method should be used.";
@@ -131,6 +129,9 @@
const base::TimeTicks& delayed_work_time) OVERRIDE {
Waitable::GetInstance()->Signal();
}
+
+ protected:
+ virtual ~MessagePumpForUIStub() {}
};
base::MessagePump* CreateMessagePumpForUIStub() {

Powered by Google App Engine
This is Rietveld 408576698