trunk/src/base/message_loop/message_pump_libevent_unittest.cc - Issue 19737005: Revert 212948 "Made MessagePump a non-thread safe class."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: trunk/src/base/message_loop/message_pump_libevent_unittest.cc

Issue 19737005: Revert 212948 "Made MessagePump a non-thread safe class." (Closed) Base URL: svn://svn.chromium.org/chrome/

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: trunk/src/base/message_loop/message_pump_libevent_unittest.cc

===================================================================

--- trunk/src/base/message_loop/message_pump_libevent_unittest.cc (revision 212951)

+++ trunk/src/base/message_loop/message_pump_libevent_unittest.cc (working copy)

@@ -122,7 +122,7 @@

};

TEST_F(MessagePumpLibeventTest, DeleteWatcher) {

- scoped_ptr<MessagePumpLibevent> pump(new MessagePumpLibevent);

+ scoped_refptr<MessagePumpLibevent> pump(new MessagePumpLibevent);

MessagePumpLibevent::FileDescriptorWatcher* watcher =

new MessagePumpLibevent::FileDescriptorWatcher;

DeleteWatcher delegate(watcher);

@@ -147,7 +147,7 @@

};

TEST_F(MessagePumpLibeventTest, StopWatcher) {

- scoped_ptr<MessagePumpLibevent> pump(new MessagePumpLibevent);

+ scoped_refptr<MessagePumpLibevent> pump(new MessagePumpLibevent);

MessagePumpLibevent::FileDescriptorWatcher watcher;

StopWatcher delegate(&watcher);

pump->WatchFileDescriptor(pipefds_[1],