Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Unified Diff: trunk/src/chrome/browser/ui/cocoa/browser/avatar_menu_bubble_controller_unittest.mm

Issue 19737005: Revert 212948 "Made MessagePump a non-thread safe class." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/chrome/browser/ui/cocoa/browser/avatar_menu_bubble_controller_unittest.mm
===================================================================
--- trunk/src/chrome/browser/ui/cocoa/browser/avatar_menu_bubble_controller_unittest.mm (revision 212951)
+++ trunk/src/chrome/browser/ui/cocoa/browser/avatar_menu_bubble_controller_unittest.mm (working copy)
@@ -5,7 +5,6 @@
#import "chrome/browser/ui/cocoa/browser/avatar_menu_bubble_controller.h"
#include "base/mac/scoped_nsobject.h"
-#include "base/memory/scoped_ptr.h"
#include "base/message_loop/message_pump_mac.h"
#include "base/strings/utf_string_conversions.h"
#include "chrome/browser/prefs/pref_service_syncable.h"
@@ -143,7 +142,7 @@
@interface TestingAvatarMenuItemController : AvatarMenuItemController
<NSAnimationDelegate> {
@private
- scoped_ptr<base::MessagePumpNSRunLoop> pump_;
+ scoped_refptr<base::MessagePumpNSRunLoop> pump_;
}
// After calling |-highlightForEventType:| an animation will possibly be
// started. Since the animation is non-blocking, the run loop will need to be
@@ -153,8 +152,8 @@
@implementation TestingAvatarMenuItemController
- (void)runMessagePump {
- if (!pump_)
- pump_.reset(new base::MessagePumpNSRunLoop);
+ if (!pump_.get())
+ pump_ = new base::MessagePumpNSRunLoop;
pump_->Run(NULL);
}

Powered by Google App Engine
This is Rietveld 408576698