Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 1973343003: Initial implementation of GeometryMapper (Closed)

Created:
4 years, 7 months ago by chrishtr
Modified:
4 years, 5 months ago
Reviewers:
Xianzhu, wkorman
CC:
blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, kinuko+watch, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Initial implementation of GeometryMapper Design document: https://docs.google.com/document/d/1WZKlOSUK4XI0Le0fgCsyUTVw0dTwutZXGWwzlHXewiU/edit This patch implements the GeometryMapper class, with these methods: LocalToVisibleRectInAncestorSpace: conceptually equivalent to LayoutObject::mapToVisualRectInAncestorSpace LocalToAncestorRect: conceptually equivalent to LayoutObject::mapLocalToAncestor AncestorToLocalRect: conceptually equivalent to LayoutObject::mapAncestorToLocal Over time, this class plus the property tree builder will replace most of the use cases of the above referenced methods. Committed: https://crrev.com/9de57cf7d69d8b30d5ae66c902d6a9d501e68664 Cr-Commit-Position: refs/heads/master@{#401710}

Patch Set 1 #

Patch Set 2 : none #

Patch Set 3 : none #

Patch Set 4 : none #

Patch Set 5 : none #

Patch Set 6 : none #

Patch Set 7 : none #

Patch Set 8 : none #

Total comments: 43

Patch Set 9 : none #

Total comments: 2

Patch Set 10 : none #

Patch Set 11 : none #

Patch Set 12 : none #

Unified diffs Side-by-side diffs Delta from patch set Stats (+615 lines, -0 lines) Patch
M third_party/WebKit/Source/platform/blink_platform.gypi View 1 2 3 4 5 6 7 8 9 10 3 chunks +4 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.h View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +104 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.cpp View 1 2 3 4 5 6 7 8 1 chunk +147 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/platform/graphics/paint/GeometryMapperTest.cpp View 1 2 3 4 5 6 7 8 9 10 1 chunk +312 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/platform/graphics/paint/PropertyTreeState.h View 1 2 3 4 5 6 7 8 1 chunk +33 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/README.md View 1 2 3 4 1 chunk +14 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/transforms/TransformationMatrix.h View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 21 (10 generated)
chrishtr
4 years, 6 months ago (2016-06-22 22:02:13 UTC) #5
Xianzhu
This is awesome! Only comments about minor issues. https://codereview.chromium.org/1973343003/diff/140001/third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.cpp File third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.cpp (right): https://codereview.chromium.org/1973343003/diff/140001/third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.cpp#newcode53 third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.cpp:53: PrecomputedDataForAncestor* ...
4 years, 6 months ago (2016-06-22 23:20:31 UTC) #6
wkorman
https://codereview.chromium.org/1973343003/diff/140001/third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.cpp File third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.cpp (right): https://codereview.chromium.org/1973343003/diff/140001/third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.cpp#newcode55 third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.cpp:55: auto first = m_data.add(ancestorState.transform, PrecomputedDataForAncestor()); nit: believe this will ...
4 years, 6 months ago (2016-06-22 23:33:33 UTC) #7
chrishtr
https://codereview.chromium.org/1973343003/diff/140001/third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.cpp File third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.cpp (right): https://codereview.chromium.org/1973343003/diff/140001/third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.cpp#newcode53 third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.cpp:53: PrecomputedDataForAncestor* GeometryMapper::GetPrecomputedDataForAncestor(const PropertyTreeState& ancestorState) On 2016/06/22 at 23:20:30, Xianzhu ...
4 years, 6 months ago (2016-06-23 00:18:27 UTC) #8
wkorman
lgtm https://codereview.chromium.org/1973343003/diff/160001/third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.h File third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.h (right): https://codereview.chromium.org/1973343003/diff/160001/third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.h#newcode43 third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.h:43: // The runtime of m calls among LocalToVisualeRectInAncestorSpace, ...
4 years, 6 months ago (2016-06-23 00:41:10 UTC) #9
chrishtr
https://codereview.chromium.org/1973343003/diff/160001/third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.h File third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.h (right): https://codereview.chromium.org/1973343003/diff/160001/third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.h#newcode43 third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.h:43: // The runtime of m calls among LocalToVisualeRectInAncestorSpace, LocalToAncestorRect ...
4 years, 5 months ago (2016-06-23 15:51:18 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1973343003/180001
4 years, 5 months ago (2016-06-23 15:51:36 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/182176)
4 years, 5 months ago (2016-06-23 16:43:57 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1973343003/220001
4 years, 5 months ago (2016-06-23 18:07:31 UTC) #18
commit-bot: I haz the power
Committed patchset #12 (id:220001)
4 years, 5 months ago (2016-06-23 20:45:50 UTC) #19
commit-bot: I haz the power
4 years, 5 months ago (2016-06-23 20:47:59 UTC) #21
Message was sent while issue was closed.
Patchset 12 (id:??) landed as
https://crrev.com/9de57cf7d69d8b30d5ae66c902d6a9d501e68664
Cr-Commit-Position: refs/heads/master@{#401710}

Powered by Google App Engine
This is Rietveld 408576698