Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 1958603002: Simplify SkGpuBlurUtils::GaussianBlur method (Closed)

Created:
4 years, 7 months ago by robertphillips
Modified:
4 years, 7 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Simplify SkGpuBlurUtils::GaussianBlur method No one was using the canClobberSrc capability and moving the direct filtering case forward makes the rest of the logic simpler. Split out of: https://codereview.chromium.org/1959493002/ (Retract GrRenderTarget from SkGpuBlurUtils) GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1958603002 Committed: https://skia.googlesource.com/skia/+/56a85e69a8d034e0fdee00e8207cda0a9da06fee

Patch Set 1 #

Patch Set 2 : Fix indents #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -101 lines) Patch
M include/gpu/GrContext.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/effects/SkBlurImageFilter.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/effects/SkBlurMaskFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkGpuBlurUtils.h View 2 chunks +0 lines, -3 lines 0 comments Download
M src/effects/SkGpuBlurUtils.cpp View 1 5 chunks +92 lines, -93 lines 0 comments Download
M src/gpu/GrContext.cpp View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
robertphillips
4 years, 7 months ago (2016-05-06 13:10:16 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1958603002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1958603002/1
4 years, 7 months ago (2016-05-06 13:10:32 UTC) #7
bsalomon
lgtm
4 years, 7 months ago (2016-05-06 13:34:21 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1958603002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1958603002/20001
4 years, 7 months ago (2016-05-06 13:35:02 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-06 13:55:54 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1958603002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1958603002/20001
4 years, 7 months ago (2016-05-06 14:03:12 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/56a85e69a8d034e0fdee00e8207cda0a9da06fee
4 years, 7 months ago (2016-05-06 14:17:53 UTC) #17
jvanverth1
4 years, 7 months ago (2016-05-06 20:04:51 UTC) #18
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1956023002/ by jvanverth@google.com.

The reason for reverting is: Looks like it's causing some issues with the
bleed_image GM..

Powered by Google App Engine
This is Rietveld 408576698