Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1959493002: Retract GrRenderTarget from SkGpuBlurUtils

Created:
4 years, 7 months ago by robertphillips
Modified:
4 years, 7 months ago
Reviewers:
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Retract GrRenderTarget from SkGpuBlurUtils Split into: https://codereview.chromium.org/1958603002/ (Simplify SkGpuBlurUtils::GaussianBlur method) https://codereview.chromium.org/1962903003/ (Make SkGpuBlurUtils::GaussianBlur more drawContext centric) https://codereview.chromium.org/1968603003/ (Swap SkGpuBlurUtils over to using SkIRects) GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1959493002

Patch Set 1 #

Patch Set 2 : update #

Patch Set 3 : update to ToT #

Patch Set 4 : Clean up #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -114 lines) Patch
M include/core/SkMaskFilter.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M include/core/SkScalar.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/core/SkMaskFilter.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkBlurImageFilter.cpp View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M src/effects/SkBlurMaskFilter.cpp View 1 2 3 4 chunks +10 lines, -8 lines 0 comments Download
M src/effects/SkGpuBlurUtils.h View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M src/effects/SkGpuBlurUtils.cpp View 1 2 3 16 chunks +96 lines, -79 lines 0 comments Download
M src/gpu/GrBlurUtils.cpp View 1 2 8 chunks +16 lines, -19 lines 0 comments Download

Messages

Total messages: 5 (5 generated)
robertphillips
Description was changed from ========== Retract GrRenderTarget from GrBlurUtils ========== to ========== Retract GrRenderTarget from ...
4 years, 7 months ago (2016-05-05 21:48:37 UTC) #1
robertphillips
Description was changed from ========== Retract GrRenderTarget from GrBlurUtils GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1959493002 ========== to ========== Retract ...
4 years, 7 months ago (2016-05-06 13:07:48 UTC) #2
robertphillips
Description was changed from ========== Retract GrRenderTarget from SkGpuBlurUtils GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1959493002 ========== to ========== Retract ...
4 years, 7 months ago (2016-05-06 13:13:57 UTC) #3
robertphillips
Description was changed from ========== Retract GrRenderTarget from SkGpuBlurUtils Split into: https://codereview.chromium.org/1958603002/ (Simplify SkGpuBlurUtils::GaussianBlur method) ...
4 years, 7 months ago (2016-05-10 17:31:56 UTC) #4
robertphillips
4 years, 7 months ago (2016-05-11 18:17:14 UTC) #5 
Description was changed from

==========
Retract GrRenderTarget from SkGpuBlurUtils

Split into:
   https://codereview.chromium.org/1958603002/ (Simplify
SkGpuBlurUtils::GaussianBlur method)
   https://codereview.chromium.org/1962903003/ (Make
SkGpuBlurUtils::GaussianBlur more drawContext centric)


GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Retract GrRenderTarget from SkGpuBlurUtils

Split into:
   https://codereview.chromium.org/1958603002/ (Simplify
SkGpuBlurUtils::GaussianBlur method)
   https://codereview.chromium.org/1962903003/ (Make
SkGpuBlurUtils::GaussianBlur more drawContext centric)
   https://codereview.chromium.org/1968603003/ (Swap SkGpuBlurUtils over to
using SkIRects)


GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

Powered by Google App Engine
This is Rietveld 408576698