DevTools: simplify NetworkProject.addFileForURL method

DevTools: simplify NetworkProject.addFileForURL method

The first "url" parameter of NetworkProject.addFileForURL method is not
needed - contentProvider already have associated URL.

As the "url" parameter goes away, this patch also renames
addFileForURL(url, contentProvider, frame) into addFile(contentProvider, frame).

BUG=610061
R=pfeldman

Committed: https://crrev.com/ecff28a9f64c5657409fc62bfda4ed5c328581e3
Cr-Commit-Position: refs/heads/master@{#392509}

[lushnikov, 2016-05-07 10:18:01]

please, take a look!

[lushnikov, 2016-05-07 10:18:08]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-07 10:18:16]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1957053002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1957053002/20001

[lushnikov, 2016-05-07 10:37:45]

Description was changed from

==========
DevTools: simplify NetworkProject.addFileForURL method

The first "url" parameter of NetworkProject.addFileForURL method is not
needed - contentProvider already have associated URL.

BUG=610061
R=pfeldman
==========

to

==========
DevTools: simplify NetworkProject.addFileForURL method

The first "url" parameter of NetworkProject.addFileForURL method is not
needed - contentProvider already have associated URL.

As the "url" parameter goes away, this patch also renames 
addFileForURL(url, contentProvider, frame) into addFile(contentProvider, frame).

BUG=610061
R=pfeldman
==========

[commit-bot: I haz the power, 2016-05-07 11:14:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-07 11:14:50]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[lushnikov, 2016-05-09 20:50:35]

The CQ bit was checked by lushnikov@chromium.org

[lushnikov, 2016-05-09 20:50:37]

The CQ bit was unchecked by lushnikov@chromium.org

[lushnikov, 2016-05-09 20:50:54]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2016-05-09 20:51:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1957053002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1957053002/20001

[commit-bot: I haz the power, 2016-05-09 20:51:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-09 20:51:36]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[lushnikov, 2016-05-09 21:35:40]

lushnikov@chromium.org changed reviewers:
+ dgozman@chromium.org

[lushnikov, 2016-05-09 21:36:00]

Dmitry, please take a look!

[dgozman, 2016-05-09 21:55:35]

lgtm

https://codereview.chromium.org/1957053002/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js
(right):

https://codereview.chromium.org/1957053002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js:243:
return new
WebInspector.StaticContentProvider(WebInspector.resourceTypes.WebSocket,
this._dataText, "");
Let's use request url.

https://codereview.chromium.org/1957053002/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/sources/ScriptFormatterEditorAction.js
(right):

https://codereview.chromium.org/1957053002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/ScriptFormatterEditorAction.js:371:
var contentProvider = new
WebInspector.StaticContentProvider(uiSourceCode.contentType(), formattedContent,
uiSourceCode.contentURL());
uiSourceCode.url() + ":formatted"

[lushnikov, 2016-05-09 22:07:00]

https://codereview.chromium.org/1957053002/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js
(right):

https://codereview.chromium.org/1957053002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js:243:
return new
WebInspector.StaticContentProvider(WebInspector.resourceTypes.WebSocket,
this._dataText, "");
On 2016/05/09 21:55:35, dgozman wrote:
> Let's use request url.

Done.

https://codereview.chromium.org/1957053002/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/sources/ScriptFormatterEditorAction.js
(right):

https://codereview.chromium.org/1957053002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/ScriptFormatterEditorAction.js:371:
var contentProvider = new
WebInspector.StaticContentProvider(uiSourceCode.contentType(), formattedContent,
uiSourceCode.contentURL());
On 2016/05/09 21:55:35, dgozman wrote:
> uiSourceCode.url() + ":formatted"

Done.

[lushnikov, 2016-05-09 22:07:06]

The CQ bit was checked by lushnikov@chromium.org

[lushnikov, 2016-05-09 22:07:07]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/1957053002/#ps40001
(title: "address comments")

[commit-bot: I haz the power, 2016-05-09 22:07:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1957053002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1957053002/40001

[commit-bot: I haz the power, 2016-05-10 01:32:42]

Description was changed from

==========
DevTools: simplify NetworkProject.addFileForURL method

The first "url" parameter of NetworkProject.addFileForURL method is not
needed - contentProvider already have associated URL.

As the "url" parameter goes away, this patch also renames 
addFileForURL(url, contentProvider, frame) into addFile(contentProvider, frame).

BUG=610061
R=pfeldman
==========

to

==========
DevTools: simplify NetworkProject.addFileForURL method

The first "url" parameter of NetworkProject.addFileForURL method is not
needed - contentProvider already have associated URL.

As the "url" parameter goes away, this patch also renames 
addFileForURL(url, contentProvider, frame) into addFile(contentProvider, frame).

BUG=610061
R=pfeldman
==========

[commit-bot: I haz the power, 2016-05-10 01:32:44]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-10 01:34:27]

Description was changed from

==========
DevTools: simplify NetworkProject.addFileForURL method

The first "url" parameter of NetworkProject.addFileForURL method is not
needed - contentProvider already have associated URL.

As the "url" parameter goes away, this patch also renames 
addFileForURL(url, contentProvider, frame) into addFile(contentProvider, frame).

BUG=610061
R=pfeldman
==========

to

==========
DevTools: simplify NetworkProject.addFileForURL method

The first "url" parameter of NetworkProject.addFileForURL method is not
needed - contentProvider already have associated URL.

As the "url" parameter goes away, this patch also renames
addFileForURL(url, contentProvider, frame) into addFile(contentProvider, frame).

BUG=610061
R=pfeldman

Committed: https://crrev.com/ecff28a9f64c5657409fc62bfda4ed5c328581e3
Cr-Commit-Position: refs/heads/master@{#392509}
==========

[commit-bot: I haz the power, 2016-05-10 01:34:28]

Patchset 3 (id:??) landed as
https://crrev.com/ecff28a9f64c5657409fc62bfda4ed5c328581e3
Cr-Commit-Position: refs/heads/master@{#392509}