third_party/WebKit/LayoutTests/inspector/sources/debugger/navigator-view.html - Issue 1957053002: DevTools: simplify NetworkProject.addFileForURL method

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/inspector/sources/debugger/navigator-view.html

Issue 1957053002: DevTools: simplify NetworkProject.addFileForURL method (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/ui-source-code-display-name.html ('k') | third_party/WebKit/LayoutTests/inspector/sources/sources-panel-extension-names.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/inspector/sources/debugger/navigator-view.html

diff --git a/third_party/WebKit/LayoutTests/inspector/sources/debugger/navigator-view.html b/third_party/WebKit/LayoutTests/inspector/sources/debugger/navigator-view.html

index ced0e9dee154c6f6a855f0869668cb8cbf112152..5815148a13c71f0e6165e3d1e6b736c69bbf5c10 100644

--- a/third_party/WebKit/LayoutTests/inspector/sources/debugger/navigator-view.html

+++ b/third_party/WebKit/LayoutTests/inspector/sources/debugger/navigator-view.html

@@ -30,15 +30,15 @@ function test()

var uiSourceCodes = [];

function addUISourceCode(url, isContentScript, frame)

{

- var contentProvider = new WebInspector.StaticContentProvider(WebInspector.resourceTypes.Script, "");

- var uiSourceCode = networkProject1.addFileForURL(url, contentProvider, frame || mainFrame);

+ var contentProvider = new WebInspector.StaticContentProvider(WebInspector.resourceTypes.Script, "", url);

+ var uiSourceCode = networkProject1.addFile(contentProvider, frame || mainFrame);

uiSourceCodes.push(uiSourceCode);

}

function addUISourceCode2(url, isContentScript)

{

- var contentProvider = new WebInspector.StaticContentProvider(WebInspector.resourceTypes.Script, "");

- var uiSourceCode = networkProject2.addFileForURL(url, contentProvider, target2.resourceTreeModel.mainFrame);

+ var contentProvider = new WebInspector.StaticContentProvider(WebInspector.resourceTypes.Script, "", url);

+ var uiSourceCode = networkProject2.addFile(contentProvider, target2.resourceTreeModel.mainFrame);

uiSourceCodes.push(uiSourceCode);

}