Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 1917863008: DevTools: [SASS] introduce Gonzales-PE for SCSS parsing (Closed)

Created:
4 years, 7 months ago by lushnikov
Modified:
4 years, 7 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: [SASS] introduce Gonzales-PE for SCSS parsing The patch kills hand-made SCSS parser and substitues it with gonzales-PE. The gonzales is bundled as a "remote" module, which means it won't increase chrome binary size. BUG=none NOTRY=true R=dgozman@chromium.org Committed: https://crrev.com/e3275efdea7977fad6758109f912be69b335e40f Cr-Commit-Position: refs/heads/master@{#390592}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : fix compilation #

Total comments: 10

Patch Set 5 : extension point #

Total comments: 6

Patch Set 6 : nits #

Patch Set 7 : rebaseline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2546 lines, -218 lines) Patch
M third_party/WebKit/LayoutTests/inspector/sass/sass-test.js View 1 2 1 chunk +1 line, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sass/test-ast-scss-3-expected.txt View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sass/test-ast-scss-5-expected.txt View 1 2 2 chunks +5 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/devtools/BUILD.gn View 1 2 3 3 chunks +8 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/devtools.gyp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/devtools.gypi View 1 2 3 4 3 chunks +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/common/FormatterWorkerPool.js View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/externs.js View 1 2 3 1 chunk +38 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/formatter_worker.json View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/formatter_worker/FormatterWorker.js View 1 2 3 4 5 2 chunks +35 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/formatter_worker/module.json View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/devtools/front_end/gonzales/MIT-LICENSE.txt View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
A third_party/WebKit/Source/devtools/front_end/gonzales/SCSSParser.js View 1 2 3 4 5 1 chunk +197 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/devtools/front_end/gonzales/gonzales-scss.js View 1 2 1 chunk +2191 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/devtools/front_end/gonzales/module.json View 1 2 3 4 5 1 chunk +19 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sass/ASTService.js View 3 chunks +1 line, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sass/SASSSupport.js View 1 2 3 4 1 chunk +35 lines, -189 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/CSSModel.js View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 31 (15 generated)
lushnikov
ptal
4 years, 7 months ago (2016-04-29 00:48:50 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1917863008/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1917863008/60001
4 years, 7 months ago (2016-04-29 00:49:26 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/175012)
4 years, 7 months ago (2016-04-29 01:04:29 UTC) #7
dgozman
https://codereview.chromium.org/1917863008/diff/60001/third_party/WebKit/Source/devtools/front_end/formatter_worker/SCSSParser.js File third_party/WebKit/Source/devtools/front_end/formatter_worker/SCSSParser.js (right): https://codereview.chromium.org/1917863008/diff/60001/third_party/WebKit/Source/devtools/front_end/formatter_worker/SCSSParser.js#newcode29 third_party/WebKit/Source/devtools/front_end/formatter_worker/SCSSParser.js:29: this._content = content; Stateless! https://codereview.chromium.org/1917863008/diff/60001/third_party/WebKit/Source/devtools/front_end/formatter_worker/SCSSParser.js#newcode30 third_party/WebKit/Source/devtools/front_end/formatter_worker/SCSSParser.js:30: return self.runtime.loadModulePromise("gonzales") Let's ...
4 years, 7 months ago (2016-04-29 01:16:17 UTC) #8
lushnikov
all done! https://codereview.chromium.org/1917863008/diff/60001/third_party/WebKit/Source/devtools/front_end/formatter_worker/SCSSParser.js File third_party/WebKit/Source/devtools/front_end/formatter_worker/SCSSParser.js (right): https://codereview.chromium.org/1917863008/diff/60001/third_party/WebKit/Source/devtools/front_end/formatter_worker/SCSSParser.js#newcode29 third_party/WebKit/Source/devtools/front_end/formatter_worker/SCSSParser.js:29: this._content = content; On 2016/04/29 01:16:17, dgozman ...
4 years, 7 months ago (2016-04-29 01:55:42 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1917863008/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1917863008/80001
4 years, 7 months ago (2016-04-29 01:57:03 UTC) #11
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/175039)
4 years, 7 months ago (2016-04-29 02:04:41 UTC) #13
dgozman
lgtm https://codereview.chromium.org/1917863008/diff/80001/third_party/WebKit/Source/devtools/front_end/formatter_worker/FormatterWorker.js File third_party/WebKit/Source/devtools/front_end/formatter_worker/FormatterWorker.js (right): https://codereview.chromium.org/1917863008/diff/80001/third_party/WebKit/Source/devtools/front_end/formatter_worker/FormatterWorker.js#newcode238 third_party/WebKit/Source/devtools/front_end/formatter_worker/FormatterWorker.js:238: WebInspector.Parser = function() { } WebInspector.FormatterWorker.ContentParser https://codereview.chromium.org/1917863008/diff/80001/third_party/WebKit/Source/devtools/front_end/formatter_worker/FormatterWorker.js#newcode254 third_party/WebKit/Source/devtools/front_end/formatter_worker/FormatterWorker.js:254: ...
4 years, 7 months ago (2016-04-29 02:10:07 UTC) #14
lushnikov
https://codereview.chromium.org/1917863008/diff/80001/third_party/WebKit/Source/devtools/front_end/formatter_worker/FormatterWorker.js File third_party/WebKit/Source/devtools/front_end/formatter_worker/FormatterWorker.js (right): https://codereview.chromium.org/1917863008/diff/80001/third_party/WebKit/Source/devtools/front_end/formatter_worker/FormatterWorker.js#newcode238 third_party/WebKit/Source/devtools/front_end/formatter_worker/FormatterWorker.js:238: WebInspector.Parser = function() { } On 2016/04/29 02:10:07, dgozman ...
4 years, 7 months ago (2016-04-29 02:31:35 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1917863008/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1917863008/100001
4 years, 7 months ago (2016-04-29 02:31:56 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/175049)
4 years, 7 months ago (2016-04-29 02:39:28 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1917863008/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1917863008/100001
4 years, 7 months ago (2016-04-29 04:28:33 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/175070)
4 years, 7 months ago (2016-04-29 04:36:00 UTC) #25
commit-bot: I haz the power
Patchset 7 (id:??) landed as https://crrev.com/e3275efdea7977fad6758109f912be69b335e40f Cr-Commit-Position: refs/heads/master@{#390592}
4 years, 7 months ago (2016-04-29 04:45:46 UTC) #27
lushnikov
Committed patchset #7 (id:120001) manually as e3275efdea7977fad6758109f912be69b335e40f (presubmit successful).
4 years, 7 months ago (2016-04-29 04:46:52 UTC) #29
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:24:20 UTC) #31
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/e3275efdea7977fad6758109f912be69b335e40f
Cr-Commit-Position: refs/heads/master@{#390592}

Powered by Google App Engine
This is Rietveld 408576698