third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/breakpoint-manager.js - Issue 1957053002: DevTools: simplify NetworkProject.addFileForURL method

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/breakpoint-manager.js

Issue 1957053002: DevTools: simplify NetworkProject.addFileForURL method (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/inspector/workspace-test.js ('k') | third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/scripts-panel.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/breakpoint-manager.js

diff --git a/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/breakpoint-manager.js b/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/breakpoint-manager.js

index d058305cfb36954134b401abf29d88d6244be802..777ac20f2e898c6ba6c78863bb726d6dc5534412 100644

--- a/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/breakpoint-manager.js

+++ b/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/breakpoint-manager.js

@@ -219,9 +219,9 @@ InspectorTest.addUISourceCode = function(target, breakpointManager, url, doNotSe

if (!doNotAddScript)

InspectorTest.addScript(target, breakpointManager, url);

InspectorTest.addResult(" Adding UISourceCode: " + url);

- var contentProvider = new WebInspector.StaticContentProvider(WebInspector.resourceTypes.Script, "");

+ var contentProvider = new WebInspector.StaticContentProvider(WebInspector.resourceTypes.Script, "", url);

var binding = breakpointManager._debuggerWorkspaceBinding;

- var uiSourceCode = InspectorTest.testNetworkProject.addFileForURL(url, contentProvider, null);

+ var uiSourceCode = InspectorTest.testNetworkProject.addFile(contentProvider, null);

InspectorTest.uiSourceCodes[url] = uiSourceCode;

if (!doNotSetSourceMapping) {

breakpointManager._debuggerWorkspaceBinding.setSourceMapping(target, uiSourceCode, breakpointManager.defaultMapping);