third_party/WebKit/Source/devtools/front_end/bindings/CompilerScriptMapping.js - Issue 1957053002: DevTools: simplify NetworkProject.addFileForURL method

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/bindings/CompilerScriptMapping.js

Issue 1957053002: DevTools: simplify NetworkProject.addFileForURL method (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/sources/sources-panel-extension-names.html ('k') | third_party/WebKit/Source/devtools/front_end/bindings/NetworkProject.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/bindings/CompilerScriptMapping.js

diff --git a/third_party/WebKit/Source/devtools/front_end/bindings/CompilerScriptMapping.js b/third_party/WebKit/Source/devtools/front_end/bindings/CompilerScriptMapping.js

index afb99654b47d6561e7182359cd6dd122d1dd1c15..9ac7f5818db51b7190f31869d111ccda4b4ead3a 100644

--- a/third_party/WebKit/Source/devtools/front_end/bindings/CompilerScriptMapping.js

+++ b/third_party/WebKit/Source/devtools/front_end/bindings/CompilerScriptMapping.js

@@ -240,7 +240,7 @@ WebInspector.CompilerScriptMapping.prototype = {

var uiSourceCode = this._networkMapping.uiSourceCodeForScriptURL(sourceURL, script);

if (!uiSourceCode && !this._networkMapping.hasMappingForNetworkURL(sourceURL)) {

var contentProvider = sourceMap.sourceContentProvider(sourceURL, WebInspector.resourceTypes.SourceMapScript);

- uiSourceCode = this._networkProject.addFileForURL(sourceURL, contentProvider, WebInspector.ResourceTreeFrame.fromScript(script), script.isContentScript());

+ uiSourceCode = this._networkProject.addFile(contentProvider, WebInspector.ResourceTreeFrame.fromScript(script), script.isContentScript());

uiSourceCode[WebInspector.CompilerScriptMapping._originSymbol] = script.sourceURL;

}

if (uiSourceCode) {