third_party/WebKit/LayoutTests/http/tests/inspector/workspace-test.js - Issue 1957053002: DevTools: simplify NetworkProject.addFileForURL method

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector/workspace-test.js

Issue 1957053002: DevTools: simplify NetworkProject.addFileForURL method (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/inspector/search/sources-search-scope-many-projects.html ('k') | third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/breakpoint-manager.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/inspector/workspace-test.js

diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector/workspace-test.js b/third_party/WebKit/LayoutTests/http/tests/inspector/workspace-test.js

index ab9a6d2f962b153aeb7dea3515e2b20fb99fbfa0..d56eb36cfb1ce8413f35d65133b5378c76edb203 100644

--- a/third_party/WebKit/LayoutTests/http/tests/inspector/workspace-test.js

+++ b/third_party/WebKit/LayoutTests/http/tests/inspector/workspace-test.js

@@ -113,14 +113,14 @@ InspectorTest.waitForWorkspaceUISourceCodeRemovedEvent = function(callback, coun

InspectorTest.addMockUISourceCodeToWorkspace = function(url, type, content)

{

- var mockContentProvider = new WebInspector.StaticContentProvider(type, content);

- InspectorTest.testNetworkProject.addFileForURL(url, mockContentProvider);

+ var mockContentProvider = new WebInspector.StaticContentProvider(type, content, url);

+ InspectorTest.testNetworkProject.addFile(mockContentProvider, null, false);

}

InspectorTest.addMockUISourceCodeViaNetwork = function(url, type, content, target)

{

- var mockContentProvider = new WebInspector.StaticContentProvider(type, content);

- InspectorTest.testNetworkProject._createFile(url, mockContentProvider, target.resourceTreeModel.mainFrame, false, true);

+ var mockContentProvider = new WebInspector.StaticContentProvider(type, content, url);

+ InspectorTest.testNetworkProject.addFile(mockContentProvider, target.resourceTreeModel.mainFrame, false);

}

InspectorTest._defaultWorkspaceEventHandler = function(event)