Add test renderer host support to ExtensionServiceTestBase.

Add test renderer host support to ExtensionServiceTestBase.

ExtensionService tests may (even inadvertently) cause the creation of
RenderProcessHosts. For example, ExtensionService::AddExtension causes
the chrome.runtime.oninstalled event to be fired inside extensions which
requires a WebContents to be created.

ExtensionServiceTestBase should include a RenderViewHostTestEnabler so
that real render hosts are not created which may leak out into other
tests and cause difficult to diagnose use-after-free errors.

BUG=608064
Committed: https://crrev.com/123aab602d256ce1aa4337972be162164953da6e
Cr-Commit-Position: refs/heads/master@{#392163}

[Reilly Grant (use Gerrit), 2016-05-04 23:43:14]

Patchset #1 (id:1) has been deleted

[Reilly Grant (use Gerrit), 2016-05-04 23:43:31]

reillyg@chromium.org changed reviewers:
+ asargent@chromium.org

[Reilly Grant (use Gerrit), 2016-05-04 23:43:32]

Please take a look.

[Reilly Grant (use Gerrit), 2016-05-04 23:44:47]

Re-enable tests.

[asargent_no_longer_on_chrome, 2016-05-05 23:15:39]

nice, lgtm

[Reilly Grant (use Gerrit), 2016-05-05 23:22:06]

The CQ bit was checked by reillyg@chromium.org

[commit-bot: I haz the power, 2016-05-05 23:22:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1947683005/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1947683005/40001

[commit-bot: I haz the power, 2016-05-05 23:37:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-05 23:37:26]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Reilly Grant (use Gerrit), 2016-05-06 21:26:05]

The CQ bit was checked by reillyg@chromium.org

[Reilly Grant (use Gerrit), 2016-05-06 21:26:05]

The patchset sent to the CQ was uploaded after l-g-t-m from
asargent@chromium.org
Link to the patchset: https://codereview.chromium.org/1947683005/#ps60001
(title: "Fix tests that end up creating two RenderViewHostFactories.")

[commit-bot: I haz the power, 2016-05-06 21:26:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1947683005/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1947683005/60001

[commit-bot: I haz the power, 2016-05-06 21:32:47]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-05-06 21:34:27]

Description was changed from

==========
Add test renderer host support to ExtensionServiceTestBase.

ExtensionService tests may (even inadvertently) cause the creation of
RenderProcessHosts. For example, ExtensionService::AddExtension causes
the chrome.runtime.oninstalled event to be fired inside extensions which
requires a WebContents to be created.

ExtensionServiceTestBase should include a RenderViewHostTestEnabler so
that real render hosts are not created which may leak out into other
tests and cause difficult to diagnose use-after-free errors.

BUG=608064
==========

to

==========
Add test renderer host support to ExtensionServiceTestBase.

ExtensionService tests may (even inadvertently) cause the creation of
RenderProcessHosts. For example, ExtensionService::AddExtension causes
the chrome.runtime.oninstalled event to be fired inside extensions which
requires a WebContents to be created.

ExtensionServiceTestBase should include a RenderViewHostTestEnabler so
that real render hosts are not created which may leak out into other
tests and cause difficult to diagnose use-after-free errors.

BUG=608064

Committed: https://crrev.com/123aab602d256ce1aa4337972be162164953da6e
Cr-Commit-Position: refs/heads/master@{#392163}
==========

[commit-bot: I haz the power, 2016-05-06 21:34:28]

Patchset 3 (id:??) landed as
https://crrev.com/123aab602d256ce1aa4337972be162164953da6e
Cr-Commit-Position: refs/heads/master@{#392163}