Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: chrome/browser/extensions/bookmark_app_helper_unittest.cc

Issue 1947683005: Add test renderer host support to ExtensionServiceTestBase. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix tests that end up creating two RenderViewHostFactories. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/bookmark_app_helper_unittest.cc
diff --git a/chrome/browser/extensions/bookmark_app_helper_unittest.cc b/chrome/browser/extensions/bookmark_app_helper_unittest.cc
index 1a29e7f8f815ca5a312c49e59b0360c984c66752..766054844cd5c9f12def3f2b2b72ac8d0cc37808 100644
--- a/chrome/browser/extensions/bookmark_app_helper_unittest.cc
+++ b/chrome/browser/extensions/bookmark_app_helper_unittest.cc
@@ -12,7 +12,7 @@
#include "chrome/test/base/testing_profile.h"
#include "content/public/browser/render_process_host.h"
#include "content/public/browser/web_contents.h"
-#include "content/public/test/test_web_contents_factory.h"
+#include "content/public/test/web_contents_tester.h"
#include "extensions/browser/extension_registry.h"
#include "extensions/common/constants.h"
#include "extensions/common/extension_icon_set.h"
@@ -316,10 +316,9 @@ TEST_F(BookmarkAppHelperExtensionServiceTest, CreateBookmarkApp) {
web_app_info.title = base::UTF8ToUTF16(kAppTitle);
web_app_info.description = base::UTF8ToUTF16(kAppDescription);
- content::TestWebContentsFactory web_contents_factory;
- content::WebContents* contents =
- web_contents_factory.CreateWebContents(profile());
- TestBookmarkAppHelper helper(service_, web_app_info, contents);
+ std::unique_ptr<content::WebContents> contents(
+ content::WebContentsTester::CreateTestWebContents(profile(), nullptr));
+ TestBookmarkAppHelper helper(service_, web_app_info, contents.get());
helper.Create(base::Bind(&TestBookmarkAppHelper::CreationComplete,
base::Unretained(&helper)));
@@ -346,10 +345,9 @@ TEST_F(BookmarkAppHelperExtensionServiceTest, CreateBookmarkApp) {
TEST_F(BookmarkAppHelperExtensionServiceTest, CreateBookmarkAppWithManifest) {
WebApplicationInfo web_app_info;
- content::TestWebContentsFactory web_contents_factory;
- content::WebContents* contents =
- web_contents_factory.CreateWebContents(profile());
- TestBookmarkAppHelper helper(service_, web_app_info, contents);
+ std::unique_ptr<content::WebContents> contents(
+ content::WebContentsTester::CreateTestWebContents(profile(), nullptr));
+ TestBookmarkAppHelper helper(service_, web_app_info, contents.get());
helper.Create(base::Bind(&TestBookmarkAppHelper::CreationComplete,
base::Unretained(&helper)));

Powered by Google App Engine
This is Rietveld 408576698