Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Side by Side Diff: chrome/browser/extensions/extension_context_menu_model_unittest.cc

Issue 1947683005: Add test renderer host support to ExtensionServiceTestBase. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix tests that end up creating two RenderViewHostFactories. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/extension_context_menu_model.h" 5 #include "chrome/browser/extensions/extension_context_menu_model.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/macros.h" 9 #include "base/macros.h"
10 #include "base/memory/ptr_util.h" 10 #include "base/memory/ptr_util.h"
11 #include "base/strings/utf_string_conversions.h" 11 #include "base/strings/utf_string_conversions.h"
12 #include "chrome/app/chrome_command_ids.h" 12 #include "chrome/app/chrome_command_ids.h"
13 #include "chrome/browser/extensions/api/extension_action/extension_action_api.h" 13 #include "chrome/browser/extensions/api/extension_action/extension_action_api.h"
14 #include "chrome/browser/extensions/extension_action_runner.h" 14 #include "chrome/browser/extensions/extension_action_runner.h"
15 #include "chrome/browser/extensions/extension_action_test_util.h" 15 #include "chrome/browser/extensions/extension_action_test_util.h"
16 #include "chrome/browser/extensions/extension_service.h" 16 #include "chrome/browser/extensions/extension_service.h"
17 #include "chrome/browser/extensions/extension_service_test_base.h" 17 #include "chrome/browser/extensions/extension_service_test_base.h"
18 #include "chrome/browser/extensions/menu_manager.h" 18 #include "chrome/browser/extensions/menu_manager.h"
19 #include "chrome/browser/extensions/menu_manager_factory.h" 19 #include "chrome/browser/extensions/menu_manager_factory.h"
20 #include "chrome/browser/extensions/scripting_permissions_modifier.h" 20 #include "chrome/browser/extensions/scripting_permissions_modifier.h"
21 #include "chrome/browser/ui/browser.h" 21 #include "chrome/browser/ui/browser.h"
22 #include "chrome/browser/ui/tabs/tab_strip_model.h" 22 #include "chrome/browser/ui/tabs/tab_strip_model.h"
23 #include "chrome/common/extensions/api/context_menus.h" 23 #include "chrome/common/extensions/api/context_menus.h"
24 #include "chrome/grit/chromium_strings.h" 24 #include "chrome/grit/chromium_strings.h"
25 #include "chrome/grit/generated_resources.h" 25 #include "chrome/grit/generated_resources.h"
26 #include "chrome/test/base/test_browser_window.h" 26 #include "chrome/test/base/test_browser_window.h"
27 #include "chrome/test/base/testing_profile.h" 27 #include "chrome/test/base/testing_profile.h"
28 #include "components/crx_file/id_util.h" 28 #include "components/crx_file/id_util.h"
29 #include "content/public/test/test_web_contents_factory.h"
30 #include "content/public/test/web_contents_tester.h" 29 #include "content/public/test/web_contents_tester.h"
31 #include "extensions/browser/extension_dialog_auto_confirm.h" 30 #include "extensions/browser/extension_dialog_auto_confirm.h"
32 #include "extensions/browser/extension_registry.h" 31 #include "extensions/browser/extension_registry.h"
33 #include "extensions/browser/extension_system.h" 32 #include "extensions/browser/extension_system.h"
34 #include "extensions/browser/test_extension_registry_observer.h" 33 #include "extensions/browser/test_extension_registry_observer.h"
35 #include "extensions/browser/test_management_policy.h" 34 #include "extensions/browser/test_management_policy.h"
36 #include "extensions/common/extension_builder.h" 35 #include "extensions/common/extension_builder.h"
37 #include "extensions/common/feature_switch.h" 36 #include "extensions/common/feature_switch.h"
38 #include "extensions/common/manifest.h" 37 #include "extensions/common/manifest.h"
39 #include "extensions/common/manifest_constants.h" 38 #include "extensions/common/manifest_constants.h"
(...skipping 457 matching lines...) Expand 10 before | Expand all | Expand 10 after
497 496
498 // Add an extension with all urls. 497 // Add an extension with all urls.
499 const Extension* extension = 498 const Extension* extension =
500 AddExtensionWithHostPermission("extension", manifest_keys::kBrowserAction, 499 AddExtensionWithHostPermission("extension", manifest_keys::kBrowserAction,
501 Manifest::INTERNAL, "*://*/*"); 500 Manifest::INTERNAL, "*://*/*");
502 501
503 const GURL kActiveUrl("http://www.example.com/"); 502 const GURL kActiveUrl("http://www.example.com/");
504 const GURL kOtherUrl("http://www.google.com/"); 503 const GURL kOtherUrl("http://www.google.com/");
505 504
506 // Add a web contents to the browser. 505 // Add a web contents to the browser.
507 content::TestWebContentsFactory factory; 506 std::unique_ptr<content::WebContents> contents(
508 content::WebContents* contents = factory.CreateWebContents(profile()); 507 content::WebContentsTester::CreateTestWebContents(profile(), nullptr));
509 Browser* browser = GetBrowser(); 508 Browser* browser = GetBrowser();
510 browser->tab_strip_model()->AppendWebContents(contents, true); 509 browser->tab_strip_model()->AppendWebContents(contents.get(), true);
511 EXPECT_EQ(browser->tab_strip_model()->GetActiveWebContents(), contents); 510 EXPECT_EQ(browser->tab_strip_model()->GetActiveWebContents(), contents.get());
512 content::WebContentsTester* web_contents_tester = 511 content::WebContentsTester* web_contents_tester =
513 content::WebContentsTester::For(contents); 512 content::WebContentsTester::For(contents.get());
514 web_contents_tester->NavigateAndCommit(kActiveUrl); 513 web_contents_tester->NavigateAndCommit(kActiveUrl);
515 514
516 ExtensionActionRunner* action_runner = 515 ExtensionActionRunner* action_runner =
517 ExtensionActionRunner::GetForWebContents(contents); 516 ExtensionActionRunner::GetForWebContents(contents.get());
518 ASSERT_TRUE(action_runner); 517 ASSERT_TRUE(action_runner);
519 518
520 // Pretend the extension wants to run. 519 // Pretend the extension wants to run.
521 int run_count = 0; 520 int run_count = 0;
522 base::Closure increment_run_count(base::Bind(&Increment, &run_count)); 521 base::Closure increment_run_count(base::Bind(&Increment, &run_count));
523 action_runner->RequestScriptInjectionForTesting( 522 action_runner->RequestScriptInjectionForTesting(
524 extension, UserScript::DOCUMENT_IDLE, increment_run_count); 523 extension, UserScript::DOCUMENT_IDLE, increment_run_count);
525 524
526 ExtensionContextMenuModel menu(extension, GetBrowser(), 525 ExtensionContextMenuModel menu(extension, GetBrowser(),
527 ExtensionContextMenuModel::VISIBLE, nullptr); 526 ExtensionContextMenuModel::VISIBLE, nullptr);
(...skipping 123 matching lines...) Expand 10 before | Expand all | Expand 10 after
651 "feature_disabled_extension", manifest_keys::kBrowserAction, 650 "feature_disabled_extension", manifest_keys::kBrowserAction,
652 Manifest::INTERNAL, "http://www.google.com/*"); 651 Manifest::INTERNAL, "http://www.google.com/*");
653 ExtensionContextMenuModel feature_disabled_menu( 652 ExtensionContextMenuModel feature_disabled_menu(
654 feature_disabled_extension, GetBrowser(), 653 feature_disabled_extension, GetBrowser(),
655 ExtensionContextMenuModel::VISIBLE, nullptr); 654 ExtensionContextMenuModel::VISIBLE, nullptr);
656 EXPECT_EQ(-1, feature_disabled_menu.GetIndexOfCommandId( 655 EXPECT_EQ(-1, feature_disabled_menu.GetIndexOfCommandId(
657 ExtensionContextMenuModel::PAGE_ACCESS_SUBMENU)); 656 ExtensionContextMenuModel::PAGE_ACCESS_SUBMENU));
658 } 657 }
659 658
660 } // namespace extensions 659 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698