Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Unified Diff: chrome/browser/extensions/extension_context_menu_model_unittest.cc

Issue 1947683005: Add test renderer host support to ExtensionServiceTestBase. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix tests that end up creating two RenderViewHostFactories. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_context_menu_model_unittest.cc
diff --git a/chrome/browser/extensions/extension_context_menu_model_unittest.cc b/chrome/browser/extensions/extension_context_menu_model_unittest.cc
index 0ddd2206348a1b24ba8a868b93b8ea2b57fa646d..16aec928b5c2d16b8bfc8ef5e0386a98ee35e83b 100644
--- a/chrome/browser/extensions/extension_context_menu_model_unittest.cc
+++ b/chrome/browser/extensions/extension_context_menu_model_unittest.cc
@@ -26,7 +26,6 @@
#include "chrome/test/base/test_browser_window.h"
#include "chrome/test/base/testing_profile.h"
#include "components/crx_file/id_util.h"
-#include "content/public/test/test_web_contents_factory.h"
#include "content/public/test/web_contents_tester.h"
#include "extensions/browser/extension_dialog_auto_confirm.h"
#include "extensions/browser/extension_registry.h"
@@ -504,17 +503,17 @@ TEST_F(ExtensionContextMenuModelTest, TestPageAccessSubmenu) {
const GURL kOtherUrl("http://www.google.com/");
// Add a web contents to the browser.
- content::TestWebContentsFactory factory;
- content::WebContents* contents = factory.CreateWebContents(profile());
+ std::unique_ptr<content::WebContents> contents(
+ content::WebContentsTester::CreateTestWebContents(profile(), nullptr));
Browser* browser = GetBrowser();
- browser->tab_strip_model()->AppendWebContents(contents, true);
- EXPECT_EQ(browser->tab_strip_model()->GetActiveWebContents(), contents);
+ browser->tab_strip_model()->AppendWebContents(contents.get(), true);
+ EXPECT_EQ(browser->tab_strip_model()->GetActiveWebContents(), contents.get());
content::WebContentsTester* web_contents_tester =
- content::WebContentsTester::For(contents);
+ content::WebContentsTester::For(contents.get());
web_contents_tester->NavigateAndCommit(kActiveUrl);
ExtensionActionRunner* action_runner =
- ExtensionActionRunner::GetForWebContents(contents);
+ ExtensionActionRunner::GetForWebContents(contents.get());
ASSERT_TRUE(action_runner);
// Pretend the extension wants to run.

Powered by Google App Engine
This is Rietveld 408576698