Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1035)

Unified Diff: chrome/browser/extensions/extension_install_prompt_unittest.cc

Issue 1947683005: Add test renderer host support to ExtensionServiceTestBase. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix tests that end up creating two RenderViewHostFactories. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_install_prompt_unittest.cc
diff --git a/chrome/browser/extensions/extension_install_prompt_unittest.cc b/chrome/browser/extensions/extension_install_prompt_unittest.cc
index 63f35a92bdc4be1d68ed15f1ce425b2116a421f2..62dd137de95bde66e40f3d7934bdf18f65ce0c41 100644
--- a/chrome/browser/extensions/extension_install_prompt_unittest.cc
+++ b/chrome/browser/extensions/extension_install_prompt_unittest.cc
@@ -17,8 +17,10 @@
#include "chrome/browser/extensions/extension_service_test_with_install.h"
#include "chrome/browser/extensions/extension_util.h"
#include "chrome/test/base/testing_profile.h"
+#include "content/public/browser/web_contents.h"
#include "content/public/test/test_browser_thread_bundle.h"
#include "content/public/test/test_web_contents_factory.h"
+#include "content/public/test/web_contents_tester.h"
#include "extensions/browser/image_loader.h"
#include "extensions/common/constants.h"
#include "extensions/common/extension.h"
@@ -219,14 +221,13 @@ TEST_F(ExtensionInstallPromptTestWithService, ExtensionInstallPromptIconsTest) {
base::Bind(&SetImage, &image, image_loop.QuitClosure()));
image_loop.Run();
ASSERT_FALSE(image.IsEmpty());
- content::TestWebContentsFactory factory;
- content::WebContents* web_contents =
- factory.CreateWebContents(browser_context());
+ std::unique_ptr<content::WebContents> web_contents(
+ content::WebContentsTester::CreateTestWebContents(browser_context(),
+ nullptr));
{
- ExtensionInstallPrompt prompt(web_contents);
+ ExtensionInstallPrompt prompt(web_contents.get());
base::RunLoop run_loop;
- prompt.ShowDialog(ExtensionInstallPrompt::DoneCallback(),
- extension,
+ prompt.ShowDialog(ExtensionInstallPrompt::DoneCallback(), extension,
nullptr, // Force an icon fetch.
base::Bind(&VerifyPromptIconCallback,
run_loop.QuitClosure(), image.AsBitmap()));
@@ -234,7 +235,7 @@ TEST_F(ExtensionInstallPromptTestWithService, ExtensionInstallPromptIconsTest) {
}
{
- ExtensionInstallPrompt prompt(web_contents);
+ ExtensionInstallPrompt prompt(web_contents.get());
base::RunLoop run_loop;
gfx::ImageSkia app_icon = util::GetDefaultAppIcon();
prompt.ShowDialog(ExtensionInstallPrompt::DoneCallback(),

Powered by Google App Engine
This is Rietveld 408576698