chrome/browser/extensions/extension_service_test_base.h - Issue 1947683005: Add test renderer host support to ExtensionServiceTestBase.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_service_test_base.h

Issue 1947683005: Add test renderer host support to ExtensionServiceTestBase. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix tests that end up creating two RenderViewHostFactories. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_install_prompt_unittest.cc ('k') | tools/valgrind/gtest_exclude/unit_tests.gtest-drmemory_win32.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_service_test_base.h

diff --git a/chrome/browser/extensions/extension_service_test_base.h b/chrome/browser/extensions/extension_service_test_base.h

index 62812cd4362fb5e547b883e54286b73a501fe7c6..6a83019ac86ebb8c215a1738e9f13cef752a70f6 100644

--- a/chrome/browser/extensions/extension_service_test_base.h

+++ b/chrome/browser/extensions/extension_service_test_base.h

@@ -17,6 +17,7 @@

#include "build/build_config.h"

#include "chrome/test/base/scoped_testing_local_state.h"

#include "content/public/test/test_browser_thread_bundle.h"

+#include "content/public/test/test_renderer_host.h"

#include "content/public/test/test_utils.h"

#include "testing/gtest/include/gtest/gtest.h"

@@ -134,6 +135,9 @@ class ExtensionServiceTestBase : public testing::Test {

// after thread_bundle_ in the destruction order.

base::ShadowingAtExitManager at_exit_manager_;

+ // Enable creation of WebContents without initializing a renderer.

+ content::RenderViewHostTestEnabler rvh_test_enabler_;

std::unique_ptr<content::TestBrowserThreadBundle> thread_bundle_;

protected: