Issue 194703008: Fix lazy deopt after tagged binary ops

Issue 194703008: Fix lazy deopt after tagged binary ops (Closed)

Created:
6 years, 9 months ago by Jakob Kummerow

Modified:
6 years, 9 months ago

Reviewers:
Jarin

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix lazy deopt after tagged binary ops Also add policing code to ensure that optimized frames can in fact lazily deopt at their respective current PC when we patch them for lazy bailout. BUG=chromium:350434 LOG=y R=jarin@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19834

Patch Set 1 #

Total comments: 2

Patch Set 2 : address comment #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+209 lines, -151 lines)			Patch
M	src/a64/lithium-a64.h	View	1	2 chunks	+1 line, -5 lines	0 comments	Download
M	src/a64/lithium-a64.cc	View	1	3 chunks	+20 lines, -24 lines	0 comments	Download
M	src/a64/lithium-codegen-a64.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/a64/lithium-codegen-a64.cc	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	src/arm/lithium-arm.h	View	1	2 chunks	+1 line, -5 lines	0 comments	Download
M	src/arm/lithium-arm.cc	View	1	3 chunks	+20 lines, -24 lines	0 comments	Download
M	src/arm/lithium-codegen-arm.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/arm/lithium-codegen-arm.cc	View		2 chunks	+7 lines, -1 line	0 comments	Download
M	src/deoptimizer.cc	View		1 chunk	+24 lines, -0 lines	0 comments	Download
M	src/heap.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/hydrogen-instructions.h	View		2 chunks	+4 lines, -2 lines	0 comments	Download
M	src/hydrogen-instructions.cc	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	src/ia32/lithium-ia32.h	View	1	2 chunks	+1 line, -5 lines	0 comments	Download
M	src/ia32/lithium-ia32.cc	View	1	3 chunks	+20 lines, -25 lines	0 comments	Download
M	src/mips/lithium-codegen-mips.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/mips/lithium-codegen-mips.cc	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	src/mips/lithium-mips.h	View	1	2 chunks	+1 line, -5 lines	0 comments	Download
M	src/mips/lithium-mips.cc	View	1	3 chunks	+20 lines, -24 lines	0 comments	Download
M	src/safepoint-table.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View		2 chunks	+7 lines, -1 line	0 comments	Download
M	src/x64/lithium-x64.h	View	1	2 chunks	+1 line, -5 lines	0 comments	Download
M	src/x64/lithium-x64.cc	View	1	3 chunks	+20 lines, -24 lines	0 comments	Download
A	test/mjsunit/regress/regress-crbug-350434.js	View		1 chunk	+33 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jarin

lgtm (assuming perf impact is smallish). I really like the fix. Just one question. https://codereview.chromium.org/194703008/diff/1/src/a64/lithium-a64.cc ...

6 years, 9 months ago (2014-03-12 00:33:58 UTC) #2

Jakob Kummerow

Thanks, landing. https://codereview.chromium.org/194703008/diff/1/src/a64/lithium-a64.cc File src/a64/lithium-a64.cc (right): https://codereview.chromium.org/194703008/diff/1/src/a64/lithium-a64.cc#newcode746 src/a64/lithium-a64.cc:746: instruction_pending_deoptimization_environment_-> On 2014/03/12 00:33:58, jarin wrote: > ...

6 years, 9 months ago (2014-03-12 09:39:49 UTC) #3

Jakob Kummerow

6 years, 9 months ago (2014-03-12 09:59:56 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r19834 (tree was closed).

Expand Messages | Collapse Messages